Update node-sqlite3 to v5.0.2 & avoid to compile while installing#153
Merged
mtgto merged 2 commits intobdash-app:masterfrom Mar 6, 2021
Merged
Update node-sqlite3 to v5.0.2 & avoid to compile while installing#153mtgto merged 2 commits intobdash-app:masterfrom
mtgto merged 2 commits intobdash-app:masterfrom
Conversation
mtgto
commented
Mar 5, 2021
| @@ -2,4 +2,3 @@ save-exact true | |||
| disturl "https://electronjs.org/headers" | |||
Member
There was a problem hiding this comment.
sqlite のビルドのために入れた設定だった気がするけど何も覚えてないので動くなら yarnrc ごと消してよさそう
Collaborator
Author
There was a problem hiding this comment.
1行目は別の設定ぽいですね。（1行目も個人的には不要だとは思いますが）。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node-sqlite3 v5.0.0+ adopt N-API instead of NAN
https://github.com/mapbox/node-sqlite3/blob/master/CHANGELOG.md#500
TryGhost/node-sqlite3#830
I understand a bit about N-API, but I know it reduces time to compile sqlite3:
TryGhost/node-sqlite3#1335 (comment)