fix: JWT Signature Verification Bypass via None Algorithm#62
Merged
Conversation
beatt83
force-pushed
the
feature/security-GHSA-88q6-jcjg-hvmw
branch
5 times, most recently
from
0644799 to
78c3cac
Compare
A security risk was identified (GHSA-88q6-jcjg-hvmw), it is addressed in 2 parts. First the JWS verification will now throw an error if it detects a JWS header with algorithm `none` and a signature present. Second a new validator was added to the JWT, now its possible to easily black list certain algorithms, by default `none` will be black listed, so it requires developer opt-in to remove it from the black list.
beatt83
force-pushed
the
feature/security-GHSA-88q6-jcjg-hvmw
branch
from
78c3cac to
c9ff623
Compare
|
Another strategy I saw in other codebase is to only allow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A security risk was identified GHSA-88q6-jcjg-hvmw, it is addressed in 2 parts. First the JWS verification will now throw an error if it detects a JWS header with algorithm
noneand a signature present. Second a new validator was added to the JWT, now its possible to easily black list certain algorithms, by defaultnonewill be black listed, so it requires developer opt-in to remove it from the black list.