[Bug]: ImportError: cannot import name 'AWSSecurityGroupsClient' from 'app.clients.aws_security_groups

[cyberdometanza]

Describe the bug

When starting the actions service via docker compose up, the container crashes with the following error:

File "/app/app/services/executor_registry.py", line 23, in
from app.executors.network import AllowIPExecutor, BlockDomainExecutor, BlockIPExecutor
File "/app/app/executors/network.py", line 21, in
from app.clients.aws_security_groups import AWSSecurityGroupsClient
ImportError: cannot import name 'AWSSecurityGroupsClient' from 'app.clients.aws_security_groups' (/app/app/clients/aws_security_groups.py)

Steps to reproduce

1. docker compose up -d
2. docker logs aisoc-actions

Expected behavior

The actions service should start without import errors.

Actual behavior

The container crashes with this error:
File "/app/app/services/executor_registry.py", line 23, in
from app.executors.network import AllowIPExecutor, BlockDomainExecutor, BlockIPExecutor
File "/app/app/executors/network.py", line 21, in
from app.clients.aws_security_groups import AWSSecurityGroupsClient
ImportError: cannot import name 'AWSSecurityGroupsClient' from 'app.clients.aws_security_groups' (/app/app/clients/aws_security_groups.py)

Component

Docker / Compose

AiSOC version

AiSOC v5.1.0

Environment

OS: Linux (Ubuntu/Debian)

Checklist

• I have searched existing issues and this is not a duplicate
• I have read the CONTRIBUTING guide

[beenuar]

Root-caused and fixed in #84.

The actions service was crashing at import time because services/actions/app/executors/network.py does from app.clients.aws_security_groups import AWSSecurityGroupsClient, but the client module only exported AWSSGClient. Since this happened during executor-registry import, the whole actions worker failed to start — no executors ever registered.

The fix in #84 renames the canonical class to AWSSecurityGroupsClient (matching the executor's import) and keeps AWSSGClient as a backward-compatible alias so any out-of-tree plugins keep working. Constructor and method signatures were also reconciled with the actual call sites in network.py (full-credential + region-only-for-rollback construction, sg_id/ip/port/protocol kwargs, and correct (FromPort, ToPort) translation).

Regression test pinned in services/actions/tests/test_aws_security_groups_client.py so this can't silently come back.

[beenuar]

Resolved by #84 (merged as 01dd1f6).

Root cause: services/actions/app/executors/network.py imports AWSSecurityGroupsClient, but the module previously only exported AWSSGClient, and the constructor/method signatures didn't match what the executor passed in.

Fix: services/actions/app/clients/aws_security_groups.py was rewritten so AWSSecurityGroupsClient is the canonical export with a constructor and method signatures that match the executor's call sites. AWSSGClient is preserved as a legacy alias for any external callers.

Regression coverage: services/actions/tests/test_aws_security_groups_client.py asserts both names are importable, the constructor accepts the executor's kwargs, and network / executor_registry import cleanly without the original ImportError.