feature: Add request duration in nanoseconds#3399
Open
sfozz wants to merge 1 commit intobenoitc:masterfrom
Open
feature: Add request duration in nanoseconds#3399sfozz wants to merge 1 commit intobenoitc:masterfrom
sfozz wants to merge 1 commit intobenoitc:masterfrom
Conversation
pajod
reviewed
May 17, 2025
pajod
reviewed
May 17, 2025
| self.error_log.log(lvl, msg, *args, **kwargs) | ||
|
|
||
| def atoms(self, resp, req, environ, request_time): | ||
| def atoms(self, resp, req, environ, request_time, request_time_nanoseconds): |
Contributor
There was a problem hiding this comment.
overridden in some environments, thus adding new args is either a breaking change - or requires some annoying private superclass workaround to keep public signatures unchanged.
Author
There was a problem hiding this comment.
do you have an example where this is overridden?
sfozz
force-pushed
the
nano_duration_access_log
branch
6 times, most recently
from
160adc4 to
c94a100
Compare
So that if you have other systems that record durations to this resolution then they can be in alignment without needing calculation.
sfozz
force-pushed
the
nano_duration_access_log
branch
from
c94a100 to
9a59cee
Compare
Author
|
I've cleaned this up and made the change more intentional.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that if you have other systems that record durations to this resolution then they can be in alignment without needing calculation.
Implements: #3398