add max_connection for asgi#3511
Open
monster-anshu wants to merge 2 commits intobenoitc:masterfrom
Open
Conversation
andersio
reviewed
Mar 9, 2026
| # A connection may arrive between the server accepting and the | ||
| # worker reacting to a capacity change. Reject it with 503. | ||
| if self.worker.nr_conns > self.worker.worker_connections: | ||
| self._reject_over_limit(transport) |
There was a problem hiding this comment.
If this approach will make it into a release, I hope the 503 hard reject is an opt-in behaviour (i.e., it is a soft limit and slight oversubscribing can be allowed). Alternatively, gunicorn may do this directly on socket.accept to backpressure into the kernel, such that this hard reject can be eliminated.
Responding 503 intermittently is not always desirable (see Uvicorn's --limit-concurrency Kludex/uvicorn#1817), especially when the connection could have been backlogged via backpressure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.