Fixed - logging cleanup for invalid blocks #10160#10180
Open
sagarkhandagre998 wants to merge 1 commit intobesu-eth:mainfrom
Open
Fixed - logging cleanup for invalid blocks #10160#10180sagarkhandagre998 wants to merge 1 commit intobesu-eth:mainfrom
sagarkhandagre998 wants to merge 1 commit intobesu-eth:mainfrom
Conversation
Signed-off-by: Sagar Khandagre <sagar.khandagre998@gmail.com>
Author
|
@jframe kindly review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Logging cleanup: demote invalid-block
ERRORnoise toDEBUGin block processorsAbstractBlockProcessorwas logging atERRORfor block validation failures (state-root mismatch, blob gas mismatch, requests/BAL hash mismatch, etc.). These are expected outcomes when the network sends a genuinely invalid block — not Besu errors.MainnetBlockValidator.handleFailedBlockProcessingalready owns the canonical INFO-level"Invalid block …"message for all failure paths, making theERRORlogs both wrong-level and redundant.The state-root mismatch
ERRORwas additionally duplicated: the parallel attempt fired it, the sequential fallback fired it again, and then the validator emitted its INFO line — three log entries for one invalid block.Changes:
LOG.errorcalls inAbstractBlockProcessor.processBlockdemoted toLOG.debug.MainnetParallelBlockProcessorfallback log is now conditional:causedBy().isPresent()→ keepsLOG.info(a real local exception occurred in the parallel path)causedBy().isEmpty()→LOG.debug(deterministic block invalidity; the validator's INFO line is sufficient)Result for a genuine invalid network block:
Fixed Issue(s)
Fixed #10160
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests