Add EVM v2 tracing compatibility for getStackItem() and stackSize()#10188
Open
parthdagia05 wants to merge 1 commit intobesu-eth:mainfrom
Open
Add EVM v2 tracing compatibility for getStackItem() and stackSize()#10188parthdagia05 wants to merge 1 commit intobesu-eth:mainfrom
parthdagia05 wants to merge 1 commit intobesu-eth:mainfrom
Conversation
Enables existing OperationTracer implementations to work transparently with the v2 long[] stack by converting stack entries to Bytes on the fly when tracing requests stack data. Includes unit tests for v2 stack read-back via getStackItem() and stackSize(). Signed-off-by: Parth Dagia <parth.24bcs10414@sst.scaler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Continues the EVM v2 implementation tracked in #10131 .
Existing
OperationTracerimplementations (StreamingOperationTracer,EthTransferLogOperationTracer, etc.) callframe.getStackItem()andframe.stackSize(), which only read from the v1Bytesstack. When running with--Xevm-go-fast=true(v2), the stack is along[]array, so these methods return incorrect results.Changes
MessageFrame.getStackItem(offset)to detect v2 mode and convert 4 longs from thelong[]stack intoBytes32on the flyMessageFrame.stackSize()to returnstackTopV2when running in v2 modeMessageFrameV2TracingTestwith 8 unit tests covering: empty stack, stack size tracking, simple values, large values, zero, max uint256, offset access, and v1 backward compatibilityWhy this approach
All existing tracers work transparently without any changes they keep calling
getStackItem()and receiveBytesregardless of whether v1 or v2 is running underneath. No new interfaces or tracer refactoring needed.Fixed Issue(s)
Partial fix for #10131
Have you done the following
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests