BAL: check max item size before bal hash#10231
Draft
daniellehrner wants to merge 1 commit intobesu-eth:mainfrom
Draft
BAL: check max item size before bal hash#10231daniellehrner wants to merge 1 commit intobesu-eth:mainfrom
daniellehrner wants to merge 1 commit intobesu-eth:mainfrom
Conversation
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
matkt
requested changes
Apr 14, 2026
| if (blockAccessListBuilder.isPresent()) { | ||
| final BlockAccessList bal = blockAccessListBuilder.get().build(); | ||
|
|
||
| final long itemCost = protocolSpec.getGasCalculator().getBlockAccessListItemCost(); |
Contributor
There was a problem hiding this comment.
I don't understand why we should move the check instead of here https://github.com/besu-eth/besu/pull/10231/changes#diff-1c64951eb3a4ab551953264d66188d47c6d39aba88cc7ce273e00f5ffbc1d155L88
| * @param itemCost per-item gas cost from the gas calculator | ||
| * @return true if the BAL exceeds the gas-limit-derived item cap | ||
| */ | ||
| public static boolean exceedsItemLimit( |
Contributor
There was a problem hiding this comment.
static call seems to be wrong as it will not be possible to have a behavior linked to a specific fork anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests