Skip to content

update commons dependencies#9114

Merged
macfarla merged 6 commits intobesu-eth:mainfrom
macfarla:update-commons
Aug 27, 2025
Merged

update commons dependencies#9114
macfarla merged 6 commits intobesu-eth:mainfrom
macfarla:update-commons

Conversation

@macfarla
Copy link
Copy Markdown
Contributor

@macfarla macfarla commented Aug 27, 2025

PR description

Update commons libs and log4j

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla marked this pull request as draft August 27, 2025 03:41
@macfarla
Copy link
Copy Markdown
Contributor Author

reverting the log4j change, hitting this apache/logging-log4j2#3771 even though it indicates these are made optional in 25.1

@macfarla macfarla changed the title update commons and log4j dependencies update commons dependencies Aug 27, 2025
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla
Copy link
Copy Markdown
Contributor Author

those graalvm fields are optional but we treat warnings as errors so that's why compile still fails

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla marked this pull request as ready for review August 27, 2025 04:09
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla mentioned this pull request Aug 27, 2025
9 tasks
@macfarla macfarla enabled auto-merge (squash) August 27, 2025 05:18
@macfarla macfarla merged commit ede86e4 into besu-eth:main Aug 27, 2025
46 checks passed
siladu pushed a commit to siladu/besu that referenced this pull request Aug 28, 2025
* update commons and log4j dependencies

* changelog

* rollback log4j version

* regenerated verification metadata to purge old content

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
@macfarla macfarla deleted the update-commons branch August 28, 2025 07:07
jflo pushed a commit to jflo/besu that referenced this pull request Sep 8, 2025
* update commons and log4j dependencies

* changelog

* rollback log4j version

* regenerated verification metadata to purge old content

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Sep 8, 2025
* update commons and log4j dependencies

* changelog

* rollback log4j version

* regenerated verification metadata to purge old content

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
georgereuben pushed a commit to georgereuben/besu that referenced this pull request Sep 16, 2025
* update commons and log4j dependencies

* changelog

* rollback log4j version

* regenerated verification metadata to purge old content

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: georgereuben <reubengeorge101@gmail.com>
georgereuben pushed a commit to georgereuben/besu that referenced this pull request Sep 16, 2025
* update commons and log4j dependencies

* changelog

* rollback log4j version

* regenerated verification metadata to purge old content

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>

---------

Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: georgereuben <reubengeorge101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants