Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Upgrade to Stash 3.3.0#37

Merged
bflad merged 2 commits intobflad:masterfrom
linc01n:stash_version/3.3.0
Oct 6, 2014
Merged

Upgrade to Stash 3.3.0#37
bflad merged 2 commits intobflad:masterfrom
linc01n:stash_version/3.3.0

Conversation

@linc01n
Copy link
Copy Markdown
Collaborator

@linc01n linc01n commented Sep 17, 2014

Starting from 3.3.0, Atlassian upgraded Tomcat from 7 to 8.
Tomcat 8 removed JasperListener

Initialize the JSP runtime in Jasper's initializer to avoid need for a
Jasper-specific lifecycle listener. JasperListener has been removed. (jboynes)

From Stash 3.2.0, Atlassian changed the config path location to an
enclosing folder called shared
https://confluence.atlassian.com/display/STASHKB/Upgrading+your+Stash+home+directory+for+Stash+3.2+manually

For Stash Backup Client, Atlassian changed download path starting from
1.2.1.

Hope this will fix #35

Starting from 3.3.0, Atlassian upgraded Tomcat from 7 to 8.
Tomcat 8 removed JasperListener

> Initialize the JSP runtime in Jasper's initializer to avoid need for a
> Jasper-specific lifecycle listener. JasperListener has been removed. (jboynes)

From Stash 3.2.0, Atlassian changed the config path location to an
enclosing folder called shared
https://confluence.atlassian.com/display/STASHKB/Upgrading+your+Stash+home+directory+for+Stash+3.2+manually

For Stash Backup Client, Atlassian changed download path starting from
1.2.1.
@linc01n linc01n mentioned this pull request Sep 17, 2014
@linc01n
Copy link
Copy Markdown
Collaborator Author

linc01n commented Sep 17, 2014

I tested on centos6 and ubuntu1204 without problems.

But I can't pass kitchen test. It is giving me this error.
recipe::stash::configuration#test_0001_creates Stash properties file [/var/chef/minitest/stash/configuration_test.rb:7]: Expected path '/var/atlassian/application-data/stash/stash-config.properties' to exist

@ramonskie
Copy link
Copy Markdown
Contributor

did you tried upgrade from 3.1.0 to 3.2.0 or higher?

@linc01n
Copy link
Copy Markdown
Collaborator Author

linc01n commented Sep 30, 2014

Yes. If you use cookbook to upgrade from 3.1.0 to 3.2.0 the shared folder will automatically created for you. This PR fixes the problem with freshly deploy instance.

@ramonskie
Copy link
Copy Markdown
Contributor

👍
@bflad please check and merge this if you have some spare time left..

@bflad
Copy link
Copy Markdown
Owner

bflad commented Oct 6, 2014

Overall this looks pretty good. I'll do some additional testing.

@bflad
Copy link
Copy Markdown
Owner

bflad commented Oct 6, 2014

The configuration minitest just needs to be updated, since the default version has the file in the new location. I'll do that after merge. Thanks!

@bflad
Copy link
Copy Markdown
Owner

bflad commented Oct 6, 2014

Thanks very much for this - pulling it in!

bflad added a commit that referenced this pull request Oct 6, 2014
@bflad bflad merged commit ef00f32 into bflad:master Oct 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stash 3.2 directories changed

3 participants