This repository was archived by the owner on Jan 10, 2023. It is now read-only.
Merged
Conversation
legal90
force-pushed
the
fix-http-auth
branch
from
d19bb29 to
95f5c27
Compare
Collaborator
|
I tested on my VM. It works well. thanks @legal90 ! |
Contributor
Author
|
@bflad What do you think about adding yet another contributor for this cookbook? |
Collaborator
|
I would like to be a maintainer for this cookbook. |
Owner
|
I'll add you tomorrow morning to Github and Supermarket. On Wed, Jan 21, 2015, 9:35 PM Lincoln Lee notifications@github.com wrote:
|
Owner
|
@linc01n I've added you as a contributor on Github and Supermarket for this cookbook. Thanks so much for offering! |
Owner
|
This change LGTM - will merge and include in 3.13.x release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls back #36
Fixes #42
Authorizationheader should not be removed. It's enough to disableauth_basicmodule.cc:\ @linc01n @Martianus