Add comprehensive zero-confirmation transactions content#4608
Open
refined-element wants to merge 2 commits intobitcoin-dot-org:masterfrom
Open
Add comprehensive zero-confirmation transactions content#4608refined-element wants to merge 2 commits intobitcoin-dot-org:masterfrom
refined-element wants to merge 2 commits intobitcoin-dot-org:masterfrom
Conversation
Addresses issue bitcoin-dot-org#1216 - Content request: zero-conf transactions This PR adds a dedicated page explaining zero-confirmation transactions, covering all requested topics: - What zero-conf transactions are - Mempools and lack of mempool consensus - Double spending (zero-conf vs chain-committed) - Stuck transactions and solutions (RBF, CPFP) - Risks of accepting zero-conf - Timelocks (CLTV and CSV) and their benefits - Impossibility of instantaneous consensus - Best practices for merchants and users Bounty payment address: [email protected]
There was a problem hiding this comment.
Pull request overview
This PR adds a new dedicated “Zero-Confirmation Transactions” page and wires it into the site’s translation and routing system to address the zero-conf content gap described in issue #1216.
Changes:
- Introduces a new
_templates/zero-conf.htmlpage using the existing hero + card layout pattern, with sections covering mempools, zero-conf vs chain-committed double spends, stuck transactions, risks, timelocks (CLTV/CSV), consensus, and best practices. - Adds a new
zero-conftranslation namespace in_translations/en.ymlcontaining all page copy and headings. - Registers the
/zero-confURL in the Englishurlmapping so the new page is routable.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
_templates/zero-conf.html |
New base-layout template for the zero-confirmation transactions page, wired to the zero-conf translation keys and structured into logical content sections. |
_translations/en.yml |
Adds the zero-conf translation block (titles, explanatory text, and bullet points) and includes zero-conf in the English URL mapping for routing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
_translations/en.yml
Outdated
| consensus: "The Impossibility of Instant Consensus" | ||
| consensustext1: "A fundamental property of decentralized systems is that instant global consensus is impossible. Information takes time to propagate, and different nodes may have different views of the current state at any given moment." | ||
| consensustext2: "Bitcoin's solution is to use proof-of-work mining to establish consensus over time. Each block represents agreement on the ordering of transactions, but this agreement only emerges after the fact - not instantly." | ||
| consensustext3: "This is why confirmations matter: they represent increasing confidence that the network has reached consensus about a transaction's validity and ordering. Zero confirmations means no consensus has been reached." |
There was a problem hiding this comment.
The sentence "Zero confirmations means no consensus has been reached." is grammatically inconsistent ("zero confirmations" is plural); consider rephrasing to something like "Having zero confirmations means no consensus has been reached" or "Zero confirmations mean no consensus has been reached" for correct subject–verb agreement.
Suggested change
| consensustext3: "This is why confirmations matter: they represent increasing confidence that the network has reached consensus about a transaction's validity and ordering. Zero confirmations means no consensus has been reached." | |
| consensustext3: "This is why confirmations matter: they represent increasing confidence that the network has reached consensus about a transaction's validity and ordering. Having zero confirmations means no consensus has been reached." |
… means" Address review feedback for correct subject-verb agreement. Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive content about zero-confirmation transactions, addressing issue #1216.
New page covers:
Changes:
_templates/zero-conf.html_translations/en.yml/zero-confAddresses
This PR addresses bounty #1216: "Content request: zero-conf transactions"
#1216
Payment Address
Bitcoin address for bounty payment:
bc1qax8d6etvphms3tqqc7hy52vas4af7ezv4msvqd🤖 Generated with Claude Code