Add OneKey Classic 1S to wallet list#4655
Open
Shoyo1024 wants to merge 1 commit intobitcoin-dot-org:masterfrom
Open
Add OneKey Classic 1S to wallet list#4655Shoyo1024 wants to merge 1 commit intobitcoin-dot-org:masterfrom
Shoyo1024 wants to merge 1 commit intobitcoin-dot-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the OneKey Classic 1S hardware wallet to the wallet list, incorporating all feedback from the previous review at #4439 by @crwatkins.
Per @crwatkins's recommendation, this PR covers only the OneKey Classic 1S. OneKey Pro will be submitted in a separate PR once the remaining items on that device are resolved.
Firmware reviewed: v3.18.0 (https://github.com/OneKeyHQ/firmware-classic1s/releases/tag/v3.18.0)
Issues from #4439 addressed in this PR
checkpasstransparencyopenspechardware(per @crwatkins's recommendation, reflecting that the THD89 secure element is closed source while a public interface specification is now available for blackbox testing).Issues from #4439 addressed outside this PR
cc @crwatkins