Change 8bit optimizer blocksize 2048->256; additional bf16 support#1365
Merged
matthewdouglas merged 9 commits intomainfrom Sep 20, 2024
Merged
Change 8bit optimizer blocksize 2048->256; additional bf16 support#1365matthewdouglas merged 9 commits intomainfrom
matthewdouglas merged 9 commits intomainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
TimDettmers
reviewed
Sep 20, 2024
Collaborator
TimDettmers
left a comment
TimDettmers
left a comment
There was a problem hiding this comment.
This looks all good. The only thing that we might want to check is if the error boundaries in the tests are now improved. We want to keep the absolute and relative error tight, so that if we have a slight degradation, the tests fail again.
Member
Author
|
@TimDettmers I was able to tighten some of the tolerances. |
matthewdouglas
added a commit
to matthewdouglas/bitsandbytes
that referenced
this pull request
Oct 28, 2024
…itsandbytes-foundation#1365) * Change 8bit optimizer blocksize 2048->256; additional bf16 support * Update tolerances for 8bit optimizer tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stacks on top of #1360 with an update to the blocksize for the 8bit blockwise optimizers. Additionally, bf16 support is added for RMSprop, Adagrad, and Momentum.
@TimDettmers @Titus-von-Koeller