Skip to content

fix: test and fix compatibility with min flutter version#1510

Merged
Gustl22 merged 21 commits into
mainfrom
gustl22/min-flutter
May 24, 2023
Merged

fix: test and fix compatibility with min flutter version#1510
Gustl22 merged 21 commits into
mainfrom
gustl22/min-flutter

Conversation

@Gustl22

@Gustl22 Gustl22 commented May 17, 2023

Copy link
Copy Markdown
Collaborator

Description

  • Compatibility with min flutter version
  • Allow configure Flutter version in dispatch workflow.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22

Gustl22 commented May 24, 2023

Copy link
Copy Markdown
Collaborator Author

For some reason the tests for Windows fail on Flutter <= 3.3.x, I don't know why, and I don't have the time to debug. But I think it won't affect anyone. The lib should just work. Also I searched the flutter/engine repo and I cannot get any change log what may is hinting to why this is failing on previous Flutter versions.

@Gustl22 Gustl22 merged commit 9f39e95 into main May 24, 2023
@Gustl22 Gustl22 deleted the gustl22/min-flutter branch May 24, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants