Skip to content

feat(ios)!: Improve AudioContextIOS#1591

Merged
Gustl22 merged 9 commits into
mainfrom
gustl22/1584-ios-assertions
Aug 17, 2023
Merged

feat(ios)!: Improve AudioContextIOS#1591
Gustl22 merged 9 commits into
mainfrom
gustl22/1584-ios-assertions

Conversation

@Gustl22

@Gustl22 Gustl22 commented Aug 1, 2023

Copy link
Copy Markdown
Collaborator

Description

  • Add assertions for AudioContextIOS
  • Convert AudioContextIOS.options from List to Set

Closes #1584

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Migration instructions

Before:

const AudioContext();
const AudioContextIOS();
AudioContextIOS(options: [ /* ... */ ]);

After:

AudioContext();
AudioContextIOS();
AudioContextIOS(options: { /* ... */ });

Related Issues

Closes #1584

@Gustl22 Gustl22 changed the title feat(ios)!: Add assertions for AudioContextIOS feat(ios)!: Improve AudioContextIOS Aug 1, 2023
@Gustl22 Gustl22 marked this pull request as ready for review August 16, 2023 13:53
@Gustl22 Gustl22 requested a review from spydon August 16, 2023 13:53
@Gustl22 Gustl22 merged commit 25fbec0 into main Aug 17, 2023
@Gustl22 Gustl22 deleted the gustl22/1584-ios-assertions branch August 17, 2023 13:00
Gustl22 added a commit that referenced this pull request Oct 6, 2023
This was referenced Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audioplayers crashing since v4.0.0 when providing custom ios context for global settings

2 participants