-
-
Notifications
You must be signed in to change notification settings - Fork 890
feat(ios)!: Improve AudioContextIOS #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f818e79
feat(ios): Add assertions for AudioContextIOS
Gustl22 158bb51
some tests
Gustl22 54e25c4
Merge branch 'main' into gustl22/1584-ios-assertions
Gustl22 8f33137
fix assertions
Gustl22 13e8b67
feat!: convert AudioContextIOS.options from List to Set
Gustl22 a2bf480
fix: adapt tests & example
Gustl22 1850c75
Merge branch 'main' into gustl22/1584-ios-assertions
Gustl22 6145f0e
Merge branch 'main' into gustl22/1584-ios-assertions
Gustl22 e706d29
Merge branch 'main' into gustl22/1584-ios-assertions
Gustl22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
packages/audioplayers_platform_interface/test/audio_context_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| //ignore_for_file: avoid_redundant_argument_values | ||
|
|
||
| import 'package:audioplayers_platform_interface/audioplayers_platform_interface.dart'; | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| TestWidgetsFlutterBinding.ensureInitialized(); | ||
|
|
||
| test('Create default AudioContext', () async { | ||
| final context = AudioContext(); | ||
| expect( | ||
| context, | ||
| AudioContext( | ||
| android: const AudioContextAndroid( | ||
| isSpeakerphoneOn: false, | ||
| audioMode: AndroidAudioMode.normal, | ||
| stayAwake: false, | ||
| contentType: AndroidContentType.music, | ||
| usageType: AndroidUsageType.media, | ||
| audioFocus: AndroidAudioFocus.gain, | ||
| ), | ||
| iOS: AudioContextIOS( | ||
| category: AVAudioSessionCategory.playback, | ||
| options: const {}, | ||
| ), | ||
| ), | ||
| ); | ||
| }); | ||
|
|
||
| test('Create invalid AudioContextIOS', () async { | ||
| try { | ||
| // Throws AssertionError: | ||
| AudioContextIOS( | ||
| category: AVAudioSessionCategory.ambient, | ||
| options: const {AVAudioSessionOptions.mixWithOthers}, | ||
| ); | ||
| fail('AssertionError not thrown'); | ||
| // ignore: avoid_catches_without_on_clauses | ||
| } catch (e) { | ||
| expect(e, isInstanceOf<AssertionError>()); | ||
| expect( | ||
| (e as AssertionError).message, | ||
| 'You can set the option `mixWithOthers` explicitly only if the audio ' | ||
| 'session category is `playAndRecord`, `playback`, or `multiRoute`.'); | ||
| } | ||
| }); | ||
|
|
||
| test('Equality of AudioContextIOS', () async { | ||
| final context1 = AudioContextIOS( | ||
| category: AVAudioSessionCategory.playAndRecord, | ||
| options: const { | ||
| AVAudioSessionOptions.mixWithOthers, | ||
| AVAudioSessionOptions.defaultToSpeaker, | ||
| }, | ||
| ); | ||
| final context2 = AudioContextIOS( | ||
| category: AVAudioSessionCategory.playAndRecord, | ||
| options: const { | ||
| AVAudioSessionOptions.defaultToSpeaker, | ||
| AVAudioSessionOptions.mixWithOthers, | ||
| }, | ||
| ); | ||
| expect(context1, context2); | ||
| }); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.