Skip to content

fix: Return null for duration and position, if not available#1606

Merged
Gustl22 merged 8 commits into
mainfrom
gustl22/nullable-duration-position
Aug 17, 2023
Merged

fix: Return null for duration and position, if not available#1606
Gustl22 merged 8 commits into
mainfrom
gustl22/nullable-duration-position

Conversation

@Gustl22

@Gustl22 Gustl22 commented Aug 16, 2023

Copy link
Copy Markdown
Collaborator

Description

If no source is set, released, or the source is a live stream, the duration and position should return null.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality. They follow in test: Prefer testing on lib and platform scope #1592
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1592

@Gustl22 Gustl22 requested a review from spydon August 16, 2023 15:57
@Gustl22 Gustl22 merged commit 2a79644 into main Aug 17, 2023
@Gustl22 Gustl22 deleted the gustl22/nullable-duration-position branch August 17, 2023 11:28
Gustl22 added a commit that referenced this pull request Sep 26, 2023
# Description

If no source is set, released, or the source is a live stream, the
duration and position should return null.

(cherry picked from commit 2a79644)
Gustl22 added a commit that referenced this pull request Nov 14, 2023
# Description

If no source is set, released, or the source is a live stream, the
duration and position should return null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants