test: Prefer testing on lib and platform scope#1592
Merged
Conversation
…reteam/audioplayers into gustl22/shorter-test-runs
7 tasks
…t-runs # Conflicts: # packages/audioplayers/example/integration_test/app/app_source_test_data.dart # packages/audioplayers/example/integration_test/lib/lib_source_test_data.dart # packages/audioplayers/example/integration_test/lib_test.dart # packages/audioplayers/example/integration_test/platform_test.dart # packages/audioplayers/example/integration_test/source_test_data.dart # packages/audioplayers_linux/linux/audioplayers_linux_plugin.cc # packages/audioplayers_platform_interface/lib/src/audioplayers_platform.dart # packages/audioplayers_windows/windows/audioplayers_windows_plugin.cpp
7 tasks
…t-runs # Conflicts: # .github/workflows/test.yml
Gustl22
changed the title
spydon
approved these changes
Aug 19, 2023
Gustl22
added a commit
that referenced
this pull request
Sep 26, 2023
# Description Transition to executing the tests in the lib and platform scope rather than in the example app in order to save testing time. - Differentiate variable bit rate (VBR) in tests - Move `durationRangeMatcher` to test_utils - Comment some sources, which are considered redundant - platform tests: ReleaseMode.release, release, volume, balance, playbackRate, getDuration, getPosition, setSource, logging, error - audioplayers: Refactor complete check in `_completePrepared` - audioplayers_darwin: set url to `nil` on release (cherry picked from commit 23d0904)
Gustl22
added a commit
that referenced
this pull request
Nov 14, 2023
# Description Transition to executing the tests in the lib and platform scope rather than in the example app in order to save testing time. - Differentiate variable bit rate (VBR) in tests - Move `durationRangeMatcher` to test_utils - Comment some sources, which are considered redundant - platform tests: ReleaseMode.release, release, volume, balance, playbackRate, getDuration, getPosition, setSource, logging, error - audioplayers: Refactor complete check in `_completePrepared` - audioplayers_darwin: set url to `nil` on release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Transition from executing the tests in the lib environment rather than in the example app in order to save testing time.
durationRangeMatcherto test_utils_completePreparednilon releaseChecklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Related Issues