Skip to content

fix(android): reset prepared state on player error #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gustl22 merged 3 commits into from
Feb 14, 2023
+3 −0
Merged

fix(android): reset prepared state on player error #1425

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b39c712
fix(android): app crashes on asynchronous errors (fixes #1260)
Gustl22 Feb 11, 2023
8a0a4f8
fix(android): app crashes on asynchronous errors (fixes #1260)
Gustl22 Feb 11, 2023
34d734a
fix(android): reset prepared state on player error (fixes #1260)
Gustl22 Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...udioplayers_android/android/src/main/kotlin/xyz/luan/audioplayers/player/WrappedPlayer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,9 @@ class WrappedPlayer internal constructor(
}

fun onError(what: Int, extra: Int): Boolean {
// When an error occurs, reset player to not [prepared].
// Then no functions will be called, which end up in an illegal player state.
prepared = false
val whatMsg = if (what == MediaPlayer.MEDIA_ERROR_SERVER_DIED) {
"MEDIA_ERROR_SERVER_DIED"
} else {
Expand Down
⚡