fix: No-op on single player setAudioContext in desktop platforms#1888
Merged
Gustl22 merged 6 commits intoFeb 18, 2025
Merged
Conversation
Contributor
Author
|
Hi @Gustl22 , I'm not familiar with c++, so I'm just doing my best pattern matching as a human. 😅 Please advise me if this was the incorrect way to log the message. |
Collaborator
|
Very cool, thank you. I try to add some tests and then we can be sure it works. |
Gustl22
approved these changes
Feb 18, 2025
spydon
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calling
setAudioContexton the windows platform throws aNotImplementederror.setAudioContextis handled as a no-op in the global method call, but not in a method call for a single audio player. This PR simply adds that no-op (and log message) for a single audio player.More context is here flame-engine/flame#3498
Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Related Issues
Resolves flame-engine/flame#3498