Allow to deactivate inspection by component#31
Closed
kamaradclimber wants to merge 1 commit intobmarini:masterfrom
Closed
Allow to deactivate inspection by component#31kamaradclimber wants to merge 1 commit intobmarini:masterfrom
kamaradclimber wants to merge 1 commit intobmarini:masterfrom
Conversation
By default, knife inspect treats all components (role, cookbooks, env) Using --no-cookbooks will make it skip cookbook inspection
|
+1 |
Collaborator
There was a problem hiding this comment.
First of all, I'm sorry it took me so long to review this!
I'm not happy about what this generates for DataBagItems:
--[no-]databagitems Add or exclude databagitems from inspection
I think we need a method to do CamelCase to underscore (I really don't want a dependency on active_support for that), so we get --no-data-bag-items
gregkare
added a commit
that referenced
this pull request
Jan 6, 2015
gregkare
added a commit
that referenced
this pull request
Jan 6, 2015
Collaborator
|
I've changed the format of the option switches and refactored a bit. Still needs documentation because I can merge and release. #34 |
gregkare
added a commit
that referenced
this pull request
Jan 6, 2015
Contributor
Author
|
closed in favor of #34 |
gregkare
added a commit
that referenced
this pull request
Jan 10, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, knife inspect treats all components (role, cookbooks, env)
Using --no-cookbooks will make it skip cookbook inspection