Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
"isRoot": true,
"tools": {
"husky": {
"version": "0.7.2",
"version": "0.8.0",
"commands": [
"husky"
]
},
"csharpier": {
"version": "1.0.3",
"version": "1.2.6",
"commands": [
"csharpier"
]
Expand Down
4 changes: 2 additions & 2 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ This Code of Conduct is adapted from the [Contributor Covenant][homepage],
version 2.0,
[available here](https://www.contributor-covenant.org/version/2/0/code_of_conduct.html).

Community Impact Guidelines were inspired by [Mozilla's code of conduct
enforcement ladder](https://github.com/mozilla/diversity).
Community Impact Guidelines were inspired by
[Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity).

[homepage]: https://www.contributor-covenant.org

Expand Down
2 changes: 1 addition & 1 deletion Common.Benchmark.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
the benchmark projects that are in this solution
-->
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<SonarQubeExclude>true</SonarQubeExclude>
<ProjectName>$(AssemblyName.Replace('.Benchmarks', ''))</ProjectName>
<OutputType>Exe</OutputType>
Expand Down
2 changes: 1 addition & 1 deletion Common.Docs.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
the docs projects that are in this solution
-->
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
</PropertyGroup>
<Target Name="BuildDocs" AfterTargets="AfterBuild" BeforeTargets="PostBuildEvent">
<!-- Prevent parallel execution -->
Expand Down
6 changes: 2 additions & 4 deletions Common.Test.props
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,10 @@
the test projects that are in this solution
-->
<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<TargetFramework>net10.0</TargetFramework>
<SonarQubeExclude>true</SonarQubeExclude>
<ProjectName>$(AssemblyName.Replace('.Tests', ''))</ProjectName>
<OutputType>Exe</OutputType>
<TestingPlatformDotnetTestSupport>true</TestingPlatformDotnetTestSupport>
<UseMicrosoftTestingPlatformRunner>true</UseMicrosoftTestingPlatformRunner>
</PropertyGroup>
<Import
Project="$(MSBuildProjectDirectory)\..\$(ProjectName)\build\$(ProjectName).props"
Expand All @@ -18,7 +16,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" />
<PackageReference Include="Microsoft.Testing.Extensions.CodeCoverage" />
<PackageReference Include="xunit.v3" />
<PackageReference Include="xunit.v3.mtp-v2" />
<PackageReference Include="xunit.runner.visualstudio">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
Expand Down
4 changes: 3 additions & 1 deletion Cutout.Docs/articles/getting-started.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
# Getting Started

To use this library, simply include `Cutout.dll` in your project or grab
it from [NuGet](https://www.nuget.org/packages/Cutout/), and add a reference to it.
it from
[NuGet](https://www.nuget.org/packages/Cutout/)
, and add a reference to it.

```xml
<ItemGroup>
Expand Down
34 changes: 0 additions & 34 deletions Cutout.sln

This file was deleted.

6 changes: 6 additions & 0 deletions Cutout.slnx
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<Solution>
<Project Path="Cutout.Docs/Cutout.Docs.csproj" />
<Project Path="Cutout.Sample/Cutout.Sample.csproj" />
<Project Path="Cutout.Tests/Cutout.Tests.csproj" />
<Project Path="Cutout/Cutout.csproj" />
</Solution>
26 changes: 13 additions & 13 deletions Parent.Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@
<PackageVersion Include="Cutout" Version="1.0.0" Condition="$(BuiltInMonoRepo) != 'true'" />
<PackageVersion Include="Humanizer.Core" Version="2.14.1" />
<PackageVersion Include="Pasted" Version="1.0.0" Condition="$(BuiltInMonoRepo) != 'true'" />
<PackageVersion Include="Polyfill" Version="8.7.3" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="8.0.0" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="9.0.7" />
<PackageVersion Include="Polyfill" Version="8.9.1" />
<PackageVersion Include="Microsoft.SourceLink.GitHub" Version="10.0.103" />
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="10.0.3" />
<PackageVersion Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.11.0" />
<PackageVersion Include="Microsoft.CSharp" Version="4.7.0" />
<PackageVersion Include="System.Text.Json" Version="8.0.5" />
<PackageVersion Include="TypeNameFormatter.Sources" Version="1.1.2" />
<PackageVersion Include="ValueTaskSupplement" Version="1.1.0" />
<PackageVersion Include="Docfx.Common" Version="2.78.3" />
<PackageVersion Include="Docfx.Plugins" Version="2.78.3" />
<PackageVersion Include="Docfx.DataContracts.Common" Version="2.78.3" />
<PackageVersion Include="Docfx.Common" Version="2.78.4" />
<PackageVersion Include="Docfx.Plugins" Version="2.78.4" />
<PackageVersion Include="Docfx.DataContracts.Common" Version="2.78.4" />
<PackageVersion Include="System.Composition" Version="9.0.0" />
</ItemGroup>
<!-- Test packages -->
Expand All @@ -41,19 +41,19 @@
Version="2.0.0"
Condition="$(BuiltInMonoRepo) != 'true'"
/>
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="17.14.2" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="1.1.2" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.4.1" />
<PackageVersion Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing" Version="1.1.3" />
<PackageVersion Include="Polly" Version="8.6.2" />
<PackageVersion Include="Verify.SourceGenerators" Version="2.5.0" />
<PackageVersion Include="Verify.XunitV3" Version="30.5.0" />
<PackageVersion Include="xunit.v3" Version="3.0.0" />
<PackageVersion Include="Verify.XunitV3" Version="31.13.2" />
<PackageVersion Include="xunit.v3.mtp-v2" Version="3.2.2" />
<PackageVersion Include="xunit.runner.visualstudio" Version="3.1.3" />
</ItemGroup>
<!-- Benchmark packages -->
<ItemGroup>
<PackageVersion Include="BenchmarkDotNet" Version="0.15.2" />
<PackageVersion Include="BenchmarkDotNet.Diagnostics.dotTrace" Version="0.15.2" />
<PackageVersion Include="BenchmarkDotNet" Version="0.15.8" />
<PackageVersion Include="BenchmarkDotNet.Diagnostics.dotTrace" Version="0.15.8" />
</ItemGroup>
<!-- Pinned Transitive packages -->
<ItemGroup>
Expand Down
5 changes: 5 additions & 0 deletions global.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"test": {
"runner": "Microsoft.Testing.Platform"
}
}
Comment on lines +1 to +5

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Consider adding an sdk section to enforce the .NET 10 SDK requirement.

The "test": { "runner": "Microsoft.Testing.Platform" } config in global.json is a .NET 10 SDK native feature; on .NET 9 SDK and earlier, this section is silently ignored. Since TestingPlatformDotnetTestSupport and UseMicrosoftTestingPlatformRunner have been removed from Common.Test.props, a developer or CI agent running an older SDK would silently fall back to VSTest-only mode with no warning.

Adding an sdk section makes the minimum SDK requirement explicit and prevents the silent fallback:

💡 Optional: pin the SDK version
 {
+  "sdk": {
+    "version": "10.0.100",
+    "rollForward": "latestFeature"
+  },
   "test": {
     "runner": "Microsoft.Testing.Platform"
   }
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
"test": {
"runner": "Microsoft.Testing.Platform"
}
}
{
"sdk": {
"version": "10.0.100",
"rollForward": "latestFeature"
},
"test": {
"runner": "Microsoft.Testing.Platform"
}
}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@global.json` around lines 1 - 5, global.json currently only contains the
"test": { "runner": "Microsoft.Testing.Platform" } setting which is ignored by
SDKs older than .NET 10; add an "sdk" section to global.json to require .NET 10
(e.g., set the minimum SDK version to 10.x) so older SDKs will error instead of
silently falling back to VSTest-only mode; update the file by adding the "sdk"
object alongside the existing "test" object and optionally pin the exact SDK
version or use a roll-forward policy to control allowed updates.

Loading