Skip to content

Digest calculated in batches of sizeof(size_t)#606

Closed
grisumbras wants to merge 1 commit intoboostorg:developfrom
grisumbras:batched-digest
Closed

Digest calculated in batches of sizeof(size_t)#606
grisumbras wants to merge 1 commit intoboostorg:developfrom
grisumbras:batched-digest

Conversation

@grisumbras
Copy link
Copy Markdown
Member

@grisumbras grisumbras commented Aug 8, 2021

Fixes #601

@grisumbras grisumbras mentioned this pull request Aug 8, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 8, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.71%. Comparing base (3c80c09) to head (55cc345).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #606   +/-   ##
========================================
  Coverage    93.70%   93.71%           
========================================
  Files           91       91           
  Lines         9136     9149   +13     
========================================
+ Hits          8561     8574   +13     
  Misses         575      575           
Files with missing lines Coverage Δ
include/boost/json/detail/digest.hpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c80c09...55cc345. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grisumbras grisumbras force-pushed the batched-digest branch 2 times, most recently from f99afa3 to a97a76f Compare August 8, 2021 14:39
@cppalliance-bot
Copy link
Copy Markdown

@vinniefalco
Copy link
Copy Markdown
Member

What is the status of this?

@grisumbras
Copy link
Copy Markdown
Member Author

I've made 6 variants of this and benched them. Here are the results:
https://docs.google.com/spreadsheets/d/1WEfTLx5vEb5TduzzHt-OkAj6HnS4ku4Y4Y7C3YGIgc8/edit?usp=sharing
The 6th approach seems most promising, fairly small regression for a few tests and huge improvements for many tests. But my local benchmarking disagrees with CI as you can see on the picture posted above by the bot.

@vinniefalco
Copy link
Copy Markdown
Member

yeah the automated performance CI bot is not accurate

@cppalliance-bot
Copy link
Copy Markdown

@vinniefalco
Copy link
Copy Markdown
Member

FYI this is still on my radar, but I have to wait until I return to boost.http_proto.

@grisumbras grisumbras force-pushed the batched-digest branch 2 times, most recently from cf0143c to 9d848ed Compare June 15, 2023 14:04
@cppalliance-bot
Copy link
Copy Markdown

@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras force-pushed the batched-digest branch 9 times, most recently from 0e823dc to e174db9 Compare June 15, 2023 20:43
@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras force-pushed the batched-digest branch 4 times, most recently from 84d8b73 to 3f4f931 Compare June 16, 2023 08:04
@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras force-pushed the batched-digest branch 15 times, most recently from 632fea9 to 699a2e4 Compare June 16, 2023 14:53
@cppalliance-bot
Copy link
Copy Markdown

@cppalliance-bot
Copy link
Copy Markdown

@cppalliance-bot
Copy link
Copy Markdown

An automated preview of the documentation is available at https://606.json.prtest2.cppalliance.org/libs/json/doc/html/index.html

@cppalliance-bot
Copy link
Copy Markdown

@grisumbras
Copy link
Copy Markdown
Member Author

Abandoned in favour of #1094.

@grisumbras grisumbras closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faster digest

3 participants