Skip to content

Fix signed integer overflow in exponent parsing#614

Merged
grisumbras merged 1 commit intoboostorg:developfrom
grisumbras:fix/parse-exponent-ub
Aug 20, 2021
Merged

Fix signed integer overflow in exponent parsing#614
grisumbras merged 1 commit intoboostorg:developfrom
grisumbras:fix/parse-exponent-ub

Conversation

@grisumbras
Copy link
Copy Markdown
Member

Fix #612

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 18, 2021

Codecov Report

Merging #614 (5b45854) into develop (3f48a27) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #614   +/-   ##
========================================
  Coverage    99.05%   99.05%           
========================================
  Files           68       68           
  Lines         6114     6119    +5     
========================================
+ Hits          6056     6061    +5     
  Misses          58       58           
Impacted Files Coverage Δ
include/boost/json/basic_parser_impl.hpp 99.19% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f48a27...5b45854. Read the comment docs.

@pauldreik
Copy link
Copy Markdown
Contributor

I can (in addition to the fuzz CI job with the test cases) confirm this fixes the problem the fuzzer found. I tested all the test cases from https://oss-fuzz.com/testcases?q=group%3A5898123298340864

@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras force-pushed the fix/parse-exponent-ub branch from 045da28 to 5b45854 Compare August 20, 2021 08:56
@cppalliance-bot
Copy link
Copy Markdown

@grisumbras grisumbras merged commit 5b45854 into boostorg:develop Aug 20, 2021
@grisumbras grisumbras deleted the fix/parse-exponent-ub branch October 20, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

overflow reported by oss fuzz 37341

3 participants