Skip to content

fix handling of comment after trailing comma#727

Merged
grisumbras merged 1 commit intoboostorg:developfrom
grisumbras:fix/array-comments-comma
Jun 30, 2022
Merged

fix handling of comment after trailing comma#727
grisumbras merged 1 commit intoboostorg:developfrom
grisumbras:fix/array-comments-comma

Conversation

@grisumbras
Copy link
Copy Markdown
Member

Fix #726

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2022

Codecov Report

Merging #727 (75367a8) into develop (5874418) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #727   +/-   ##
========================================
  Coverage    99.13%   99.13%           
========================================
  Files           69       69           
  Lines         6553     6553           
========================================
  Hits          6496     6496           
  Misses          57       57           
Impacted Files Coverage Δ
include/boost/json/basic_parser_impl.hpp 99.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5874418...75367a8. Read the comment docs.

@grisumbras grisumbras merged commit 75367a8 into boostorg:develop Jun 30, 2022
@grisumbras grisumbras deleted the fix/array-comments-comma branch June 30, 2022 15:50
@cppalliance-bot
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trailing commas and comments not working well in some cases

3 participants