Fixed forced banner#124
Merged
felixgirault merged 1 commit intomainfrom Apr 15, 2025
Merged
Conversation
felixgirault
commented
Apr 15, 2025
| <Dialog | ||
| isAlert={isForced} | ||
| labelId="orejime-modal-title" | ||
| portalClassName="orejime-Env" |
Contributor
Author
There was a problem hiding this comment.
This class is already added via a container above.
When forced, the banner wasn't trapping focus as it should have. This is now fixed, and tests were added on both forced modes.
felixgirault
force-pushed
the
fix-forced-banner
branch
from
0996d4c to
f2ad694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When forced, the banner wasn't trapping focus as it should have. This is now fixed, and tests were added on both forced modes.