Remove non-existing file references from the package.json#132
Merged
felixgirault merged 1 commit intoboscop-fr:mainfrom Jul 10, 2025
Merged
Remove non-existing file references from the package.json#132felixgirault merged 1 commit intoboscop-fr:mainfrom
felixgirault merged 1 commit intoboscop-fr:mainfrom
Conversation
This removes some entries from the package.json, as these are pointing to files which don't exist. This in turn prevents the inclusion of orejime's dist-assets into bundlers, like webpack.
felixgirault
approved these changes
Jul 10, 2025
Contributor
|
Hello, Indeed, those props were set for a previous version and are not relevant anymore. Thank you! PS: You might have seen it already, but we don't recommend bundling Orejime yourself (see this note https://github.com/boscop-fr/orejime/blob/main/adr/001-distribution-formats.md) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppose you want to bundle the dist assets of
orejimeusing Webpack:Webpack errors out with the following error message:
I.e. Webpack complains, that it can't find the files from above, as these aren't exported from the NPM-package.
While having a deeper look into the
package.jsonI've figured out, that themain-,browser- andexports-properties mostly reference files, which aren't even part of the dist-package.That's why I simply removed the properties, which makes the Webpack bundling succeed! :)
It would be really nice if you could consider my PR, as I would like to switch from Klaro to orejime, as it seems to be much better maintained.