Add logic to skip invalid feature id#3639
Merged
SamRemis merged 13 commits intoboto:developfrom Mar 10, 2026
Merged
Conversation
… modeled by a service # Conflicts: # botocore/httpchecksum.py # botocore/utils.py # tests/functional/test_httpchecksum.py
Co-authored-by: jonathan343 <43360731+jonathan343@users.noreply.github.com>
…algorithm function
…_header_algorithm function" This reverts commit 175039e.
This reverts commit a1e062a.
…m_header_algorithm function" This reverts commit 8d36c8a.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3639 +/- ##
===========================================
- Coverage 92.71% 92.59% -0.12%
===========================================
Files 68 68
Lines 15561 15634 +73
===========================================
+ Hits 14428 14477 +49
- Misses 1133 1157 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ashovlin
reviewed
Feb 26, 2026
ashovlin
approved these changes
Feb 27, 2026
aws-sdk-python-automation
added a commit
that referenced
this pull request
Mar 10, 2026
* release-1.42.65: Bumping version to 1.42.65 Update to latest models Add logic to skip invalid checksum feature id (#3639)
hswong3i
pushed a commit
to alvistack/boto-botocore
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
With a recent PR, we added new get_checksum_header_algorithms function to get a list of headers that start with
x-amz-checksum-, so if we havex-amz-checksum-sha512, it would returnsha512.This function is used to set feature ids, and has a false positive for the
x-amz-checksum-algorithmheader and currently attempts to register a non-existent feature id for a checksum called "algorithm".To fix this and simplify the logic, this PR separates out the responsibilities of the functions. The old
get_checksum_header_algorithmshas been renamed toget_checksum_algorithm_headersand returns only the raw headers. The function which registers the feature ids will now filter out thex-amz-checksum-algorithmheader and extract the algorithm name from the header name for registration.Considering these changes are internal only and not public facing, I've decided against including a changelog. Happy to include one in a future revision if requested.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.