#97 helpers for more flexible tasks progression#98
Open
Skrattoune wants to merge 3 commits intoboxine:mainfrom
Open
#97 helpers for more flexible tasks progression#98Skrattoune wants to merge 3 commits intoboxine:mainfrom
Skrattoune wants to merge 3 commits intoboxine:mainfrom
Conversation
Documenting the use of the helper functions described in boxine#97
helper functions described in boxine#97 Use documented in https://github.com/boxine/django-huey-monitor/blob/master/huey_monitor_tests/test_app/tasks.py
Contributor
Author
|
No testing included |
jedie
reviewed
Mar 30, 2022
I let make_complete and make_task_complete as they are slightly different
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 83.31% 81.23% -2.08%
==========================================
Files 40 40
Lines 809 842 +33
==========================================
+ Hits 674 684 +10
- Misses 135 158 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jedie
reviewed
Dec 1, 2022
| sub_task_id=task.id, | ||
| ) | ||
| # let's consider we don't know yet the number of steps | ||
| process_info = ProcessInfo(task, desc='Recursive task execution', total=999) |
Member
There was a problem hiding this comment.
Hm. total=999 is a little bit ugly, isn't it?
Can we resolve this in a other way?
jedie
reviewed
Dec 1, 2022
|
|
||
| while continue_with_next_step: | ||
| # we execute the step: | ||
| continue_with_next_step = random.randrange(100)<80 |
Member
There was a problem hiding this comment.
Why not just a normal for loop?
e.g.:
for _ in range(random.randrange(80,100):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
helper functions described in #97
Use documented in https://github.com/boxine/django-huey-monitor/blob/master/huey_monitor_tests/test_app/tasks.pyhe use of the helper functions described in #97