[CLOSED] Updated gyp

[core-ai-bot]

Issue by ficristo
Sunday Jan 31, 2016 at 12:57 GMT
Originally opened as adobe#546

---

This is necessary to support newer compiler (in my case VS2015).
I simply copied the upstream source to the gyp folder but I've excluded the gyp/test folder from the commit.

---

ficristo included the following code: https://github.com/adobe/brackets-shell/pull/546/commits

[core-ai-bot]

Comment by ficristo
Wednesday Apr 06, 2016 at 09:16 GMT

---

@nethip @jasonsanjose
I know this will be PITA to review but would be awesome if someone could take a look.
If you think that updating gyp is better done by someone of the Brackets team let me know.
Thank you.

[core-ai-bot]

Comment by ingorichter
Thursday May 12, 2016 at 17:19 GMT

---

Builds fine on OSX for me. @ficristo are you on Windows? Anybody here to build and smoke test the Linux build? I can do it in the evening, if nobody is available.

[core-ai-bot]

Comment by ficristo
Thursday May 12, 2016 at 17:31 GMT

---

@ingorichter I've tested on Windows 7.

[core-ai-bot]

Comment by ficristo
Wednesday May 25, 2016 at 08:03 GMT

---

Finally I was able to set a VM with Linux.
@nethip @ingorichter Which branch should I test for Linux?

[core-ai-bot]

Comment by nethip
Wednesday May 25, 2016 at 08:40 GMT

---

Currently Linux builds are getting spawned from linux-1547

[core-ai-bot]

Comment by ficristo
Wednesday May 25, 2016 at 10:11 GMT

---

I tested on that branch with an updated gyp and seems to works.
I needed only to remove python2 from this command gypCommand = "bash -c 'python2 gyp/gyp --depth=.'"; in tasks/setup.js.

[core-ai-bot]

Comment by ficristo
Tuesday May 31, 2016 at 17:56 GMT

---

With the last commit I can create the project on linux too.

[core-ai-bot]

Comment by ficristo
Sunday Jun 12, 2016 at 07:52 GMT

---

@nethip @ingorichter
Now that version 1.7 has been released, is there any chance that you can review my PRs?

[core-ai-bot]

Comment by nethip
Tuesday Jun 21, 2016 at 15:46 GMT

---

LGTM. I would build this branch on VS2010 as well before merging in.

Good job @ficristo . Quite a no of changes actually!

[core-ai-bot]

Comment by nethip
Wednesday Jun 22, 2016 at 14:13 GMT

---

@ficristo I am getting following errors when I am building using VS2013.

2>appshell\appshell_extensions_win.cpp(429): error C2220: warning treated as error - no 'object' file generated
2>appshell\appshell_extensions_win.cpp(429): warning C4996: 'GetVersionExW': was declared deprecated
2>          C:\Program Files (x86)\Windows Kits\8.1\Include\um\sysinfoapi.h(442) : see declaration of 'GetVersionExW'
2>  resource_util_win.cpp
2>  cef_dark_aero_window.cpp
2>  cef_dark_window.cpp
2>  cef_host_window.cpp
2>appshell\cef_dark_aero_window.cpp(60): error C2220: warning treated as error - no 'object' file generated
2>appshell\cef_dark_aero_window.cpp(60): warning C4996: 'GetVersionExW': was declared deprecated
2>          C:\Program Files (x86)\Windows Kits\8.1\Include\um\sysinfoapi.h(442) : see declaration of 'GetVersionExW'

[core-ai-bot]

Comment by ficristo
Wednesday Jun 22, 2016 at 14:32 GMT

---

The GetVersionExW warnings should be fixed by: adobe#549

[core-ai-bot]

Comment by nethip
Wednesday Jun 22, 2016 at 14:35 GMT

---

Thanks @ficristo

[core-ai-bot]

Comment by nethip
Wednesday Jun 22, 2016 at 14:40 GMT

---

@ficristo After merging your PRs I am getting following linker errors, upon building master.

2>appshell_extensions_win.obj : error LNK2019: unresolved external symbol __imp__IsTextUnicode@12 referenced in function "bool __cdecl GetBufferAsUTF8(struct UTFValidationState &)" (?GetBufferAsUTF8@@YA_NAAUUTFValidationState@@@Z)
2>appshell_extensions_win.obj : error LNK2019: unresolved external symbol __imp__RegCloseKey@4 referenced in function "class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > __cdecl GetPathToLiveBrowser(void)" (?GetPathToLiveBrowser@@YA?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@XZ)
2>cef_registry.obj : error LNK2001: unresolved external symbol __imp__RegCloseKey@4
2>appshell_extensions_win.obj : error LNK2019: unresolved external symbol __imp__RegOpenKeyExW@20 referenced in function "class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > __cdecl GetPathToLiveBrowser(void)" (?GetPathToLiveBrowser@@YA?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@XZ)
2>cef_registry.obj : error LNK2001: unresolved external symbol __imp__RegOpenKeyExW@20
2>appshell_extensions_win.obj : error LNK2019: unresolved external symbol __imp__RegQueryValueExW@24 referenced in function "class std::basic_string<wchar_t,struct std::char_traits<wchar_t>,class std::allocator<wchar_t> > __cdecl GetPathToLiveBrowser(void)" (?GetPathToLiveBrowser@@YA?AV?$basic_string@_WU?$char_traits@_W@std@@V?$allocator@_W@2@@std@@XZ)
2>cef_registry.obj : error LNK2001: unresolved external symbol __imp__RegQueryValueExW@24
2>cef_registry.obj : error LNK2019: unresolved external symbol __imp__RegCreateKeyExW@36 referenced in function "bool __cdecl WriteRegistryInt(wchar_t const *,wchar_t const *,int)" (?WriteRegistryInt@@YA_NPB_W0H@Z)
2>cef_registry.obj : error LNK2019: unresolved external symbol __imp__RegSetValueExW@24 referenced in function "bool __cdecl WriteRegistryInt(wchar_t const *,wchar_t const *,int)" (?WriteRegistryInt@@YA_NPB_W0H@Z)
2>Release\Brackets.exe : fatal error LNK1120: 6 unresolved externals

[core-ai-bot]

Comment by nethip
Wednesday Jun 22, 2016 at 14:40 GMT

---

I am on VS 2013.

[core-ai-bot]

Comment by ingorichter
Wednesday Jun 22, 2016 at 15:47 GMT

---

@nethip what VS version does the build machine use? Do we have a followup issue that addresses the build failure?