[CLOSED] Fix full screen window issue in multiple montiors

[core-ai-bot]

Issue by sobisht
Friday Apr 13, 2018 at 10:50 GMT
Originally opened as adobe#638

---

Issue: adobe/brackets#13349

• Currently we are not handling the WM_NCPAINT for dark aero glass. This causes the issue when we delegate this handling to the OS.
  To fix this issue, I have added a handle for dark aero similar to the one present for dark window.

• This will also fix the following issue
  

The boundaries of the non client area is not correctly painted when we launch brackets in maximized window and go from maximize to restored window.
After the fix

Unit tested the fix

• On Win10 builds before and after creators update.
• On Dual monitors with different resolution
• On Dual monitors with one monitor with high DPI.

Please review @nethip @swmitra @vickramdhawal @JeffryBooher

---

sobisht included the following code: https://github.com/adobe/brackets-shell/pull/638/commits

[core-ai-bot]

Comment by nethip
Friday Apr 13, 2018 at 11:00 GMT

---

Thanks for the PR @sobisht . Great work!

I see that these are also not handled inside cef_aero_dark_window. Does it make sense to handle the following as well?

WM_NCCREATE
WM_NCDESTROY
WM_NCHITTEST

[core-ai-bot]

Comment by sobisht
Friday Apr 13, 2018 at 11:24 GMT

---

@nethip

• We are already handling WM_NCHITTEST in cef_dark_aero_window::DwpCustomFrameProc().
• The functionality related to WM_NCCREATE is done by HandleCreate() for WM_CREATE. On adding the handling of WM_NCCREATE introduces the issue again.
• And WM_NCDESTROY is handled by cef_window::WindowProc() called in cef_dark_aero_window::WindowProc().

So explicit handling of this messages might not be required.

[core-ai-bot]

Comment by nethip
Friday Apr 13, 2018 at 11:24 GMT

---

Thanks for confirming @sobisht!

[core-ai-bot]

Comment by nethip
Friday Apr 13, 2018 at 11:25 GMT

---

Thanks for fixing this @sobisht