[CLOSED] Type Inference in hint list.

[core-ai-bot]

Issue by swmitra
Monday Nov 23, 2015 at 09:39 GMT
Originally opened as adobe/brackets#11949

---

Show type data in the hint list. This is work in progress as we need more ideas about the type symbols which are just text in this PR.

A snapshot of the rendered types from this implementation.

---

swmitra included the following code: https://github.com/adobe/brackets/pull/11949/commits

[core-ai-bot]

Comment by swmitra
Monday Nov 23, 2015 at 09:39 GMT

---

Tagging@nethip@abose@ryanstewart

[core-ai-bot]

Comment by sprintr
Monday Nov 23, 2015 at 11:01 GMT

---

I believe it would be nice to show the data types as the output of typeof(instance) such as "string", "number", "function".

Edit: We can also use "keyword" to show type of keywords.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Data_structures

[core-ai-bot]

Comment by swmitra
Monday Nov 23, 2015 at 16:15 GMT

---

Thanks@sprintr. I will try that once and post a snapshot of the rendering. Our goal is to have the type data without being too loud. We have to compare different displays in order to conclude.

[core-ai-bot]

Comment by swmitra
Tuesday Nov 24, 2015 at 07:09 GMT

---

@sprintr With some CSS changes and new literals , this is how it looks.

I must confess , to me it looks cluttered.

[core-ai-bot]

Comment by petetnt
Tuesday Nov 24, 2015 at 08:48 GMT

---

@swmitra maybe aligning the literal labels to right would help (plus maybe more padding to the right side). I think that the labels the OP look pretty nice too, but then again the literals are more clearer (in a way). Maybe the labels could come from a labelProvider for a customization option 🍻

What about mixed types? For example [0, "string", {object: "foo"}]

[core-ai-bot]

Comment by abose
Tuesday Nov 24, 2015 at 08:53 GMT

---

+1 for right align.
+1 for short symbols as in the initial implementaion. Maybe a hybrid- on hover/arrow key on current selected entity, we could expand the short symbol to detailed string?

[core-ai-bot]

Comment by ficristo
Tuesday Nov 24, 2015 at 09:00 GMT

---

FWIW, I like the second screenshot with right alignment.
I looked a bit in VisualStudioCode which has the inference type too: I like it can inference the return type of a function too.

[core-ai-bot]

Comment by swmitra
Tuesday Nov 24, 2015 at 09:33 GMT

---

@petetnt@ficristo@abose@sprintr A snap with right aligned symbols and more padding.

[core-ai-bot]

Comment by swmitra
Tuesday Nov 24, 2015 at 09:35 GMT

---

@petetnt I will write a label provider which can be overridden by extensions.
autocomplete plus works in the same way I guess.
Also I have to infer a mixed type array , will update the PR with the check.

[core-ai-bot]

Comment by ficristo
Tuesday Nov 24, 2015 at 09:41 GMT

---

@swmitra Can you try to put the type on the right of the variable names?

[core-ai-bot]

Comment by abose
Tuesday Nov 24, 2015 at 09:57 GMT

---

😅 I too meant right align after the variable names!

[core-ai-bot]

Comment by sprintr
Tuesday Nov 24, 2015 at 10:32 GMT

---

This looks good. I am not sure if short names will look good in right alignment.
+1 for right alignment.

[core-ai-bot]

Comment by swmitra
Tuesday Nov 24, 2015 at 11:40 GMT

---

@sprintr@petetnt@ficristo@nethip Was trying with different styles. This one

stands out with a small css tweak.

[core-ai-bot]

Comment by swmitra
Tuesday Nov 24, 2015 at 11:44 GMT

---

@larz0@ryanstewart Please provide your inputs.

[core-ai-bot]

Comment by swmitra
Tuesday Nov 24, 2015 at 11:59 GMT

---

Some more tuning with the type details ( font-style and weight change )