[CLOSED] Make file watching compatible with node version 6.x (runs on 0.10 too)

[core-ai-bot]

Issue by zaggino
Wednesday Aug 03, 2016 at 23:53 GMT
Originally opened as adobe/brackets#12647

---

related to adobe/brackets-shell#543

trying to make brackets work with the new version of node in the shell

cc@ficristo (I couldn't commit to your repo that's why I merged your branch here)

---

zaggino included the following code: https://github.com/adobe/brackets/pull/12647/commits

[core-ai-bot]

Comment by ingorichter
Thursday Aug 04, 2016 at 05:47 GMT

---

Okay, I'm able to build on OSX. Brackets launches and changes in the opened folder will show up in the project tree. Adding a file in the finder will update the project tree. The same applies for deleting a file. The whole thing stops working, the moment I open a different folder/project. From that point on I don't receive any change notifications anymore and I'm unable to open a different folder/project.

[core-ai-bot]

Comment by zaggino
Thursday Aug 04, 2016 at 06:10 GMT

---

Thanks@ingorichter , same thing happening on Windows, I'll be looking into it when I'll have some free time.

[core-ai-bot]

Comment by zaggino
Friday Aug 05, 2016 at 00:13 GMT

---

@ingorichter opening a different project/folder should be fixed now.

[core-ai-bot]

Comment by zaggino
Friday Aug 05, 2016 at 02:50 GMT

---

Good news, all my testing is passing and I can't see any more problems. Now the question: chokidar allows pushing ignore property to the library itself to ignore some entries, which is great.

The way it currently works: brackets-web get all file change notifications (even from .git folders, and that's a heap of notifications) from brackets-shell and these are filtered on the web side.

The way it could work: brackets-web could pass filter to the brackes-shell to use with chokidar and these would be filtered on shell side which would be great (much less change events and load on the domain connection) but it would also mean that the api between web and shell would have to change. This would be concern for other brackets-web implementations which doesn't use brackets-shell.

Question is: make this breaking change in this PR or not?

@ingorichter@ficristo@petetnt@busykai@abose@MarcelGerber

[core-ai-bot]

Comment by ingorichter
Sunday Aug 07, 2016 at 06:32 GMT

---

👏 @zaggino. That works way better now. Thanks for resolving this issue.
I like the idea of having everything filtered on the shell side. Perhaps we can have a feature flag to have both available. At least for some time before dropping the current implementation. It will be a great improvement over the existing implementation and should improve the performance (at least a bit). Perhaps we could even get rid of the TOO_MANY_FILES limitation.

[core-ai-bot]

Comment by petetnt
Monday Aug 08, 2016 at 05:32 GMT

---

I am with@ingorichter with having it behind a feature flag but enabled by default. It brings huge benefits for Brackets.

Great job with this PR and the current progress with the Node update too in general, really excited about this one 👍

[core-ai-bot]

Comment by zaggino
Tuesday Aug 16, 2016 at 05:32 GMT

---

@ingorichter@petetnt implemented & tested

I've actually been using this branch and related shell build daily for a few days now "in production" and I haven't encountered any side effects.

Considering this finished, now it needs a review and hopefully a merge soon.

[core-ai-bot]

Comment by petetnt
Tuesday Aug 16, 2016 at 05:40 GMT

---

Great stuff@zaggino, I'll try this as an daily driver today and try to review the code side asap

[core-ai-bot]

Comment by zaggino
Thursday Aug 18, 2016 at 00:41 GMT

---

Excluding node_modules too, watching over them with chokidar causes problems for npm installations and updates to run in a project folder (ref npm/npm#10826 (comment)). It'd be highly unusual workflow working inside a node_modules folder anyway.

[core-ai-bot]

Comment by ingorichter
Thursday Aug 18, 2016 at 04:37 GMT

---

Okay, I'm testing it now and report back when I see things behaving weird.

[core-ai-bot]

Comment by ficristo
Thursday Aug 18, 2016 at 06:19 GMT

---

Excluding node_modules

I really hope we'll make these user configurable (followup is fine). I think, for example, we should ignore bower_components by default too.

[core-ai-bot]

Comment by zaggino
Thursday Aug 18, 2016 at 06:22 GMT

---

Followup is fine, I prefer not to build more features until this is merged.

[core-ai-bot]

Comment by ficristo
Monday Aug 22, 2016 at 18:26 GMT

---

I didn't try the PR but I left some comments regardless.
Have you tryed if the non recursive code still works?

[core-ai-bot]

Comment by zaggino
Tuesday Aug 23, 2016 at 01:15 GMT

---

Comments addressed, I haven't played with the non recursive stuff as I see little point - the code around recursiveWatch being false wasn't touched in this PR.

[core-ai-bot]

Comment by zaggino
Tuesday Aug 23, 2016 at 03:06 GMT

---

@ficristo ready for round 2, this now supports Code's CSharpWatcher in win32