[CLOSED] Issue #12859 Keyboard modifiers support for simulateKeyEvent

[core-ai-bot]

Issue by haslam22
Monday Oct 31, 2016 at 19:47 GMT
Originally opened as adobe/brackets#12863

---

Added support for sending additional arguments to simulateKeyEvent, e.g. modifiers such as ctrlKey: true or any other value supported by KeyboardEventInit.

---

haslam22 included the following code: https://github.com/adobe/brackets/pull/12863/commits

[core-ai-bot]

Comment by petetnt
Friday Nov 25, 2016 at 08:47 GMT

---

Sorry about being so slow with this, been swamped with work as of late. I'll review this on Sunday / Monday.

Again, apologies for taking so long!

[core-ai-bot]

Comment by haslam22
Friday Nov 25, 2016 at 13:12 GMT

---

No worries! Thanks for putting aside time to review this.

On 25 Nov 2016, at 08:47, Pete Nykänen notifications@github.com wrote:

Sorry about being so slow with this, been swamped with work as of late. I'll review this on Sunday / Monday.

Again, apologies for taking so long!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[core-ai-bot]

Comment by haslam22
Thursday Dec 01, 2016 at 14:54 GMT

---

Made the requested changes, and provided a unit test. Had to pop it in a new file, SpecRunnerUtils-test, hope that's fine. Let me know if anything else needs to be changed, thanks!

[core-ai-bot]

Comment by petetnt
Thursday Dec 22, 2016 at 08:40 GMT

---

I'll try and test this out for the final time today and then merge it in, LGTM so far 🥇

[core-ai-bot]

Comment by haslam22
Thursday Dec 22, 2016 at 11:16 GMT

---

Great, thanks!

On 22 Dec 2016, at 08:40, Pete Nykänen notifications@github.com wrote:

I'll try and test this out for the final time today and then merge it in, LGTM so far 🥇

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[core-ai-bot]

Comment by petetnt
Friday Dec 23, 2016 at 08:23 GMT

---

Okay, one more nitpick and then it's ready to go 👍 Great work@haslam22!

[core-ai-bot]

Comment by haslam22
Friday Dec 23, 2016 at 15:06 GMT

---

Woops, forgot to update that part. Should be all good now.

[core-ai-bot]

Comment by petetnt
Friday Dec 23, 2016 at 15:07 GMT

---

Thanks for this great contribution@haslam22!