[CLOSED] [OPEN] Move the Project Preferences Dialog variables to the template

[core-ai-bot]

Issue by TomMalbran
Friday Mar 29, 2013 at 00:56 GMT
Originally opened as adobe/brackets#3286

---

This removes the jQuery dialog populate part of the Project Preferences Dialog, and moves it all to the template, passing the required variables.

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/3286/commits

[core-ai-bot]

Comment by njx
Friday May 10, 2013 at 01:51 GMT

---

Open for committers to review.

[core-ai-bot]

Comment by redmunds
Thursday Jun 13, 2013 at 05:17 GMT

---

I'm ready to look at this one, but there's a merge conflict.

[core-ai-bot]

Comment by TomMalbran
Friday Jun 14, 2013 at 00:34 GMT

---

@redmunds Thanks for the review. I fixed the merge issues, updated the template and fixed the 3 curly braces issue.

[core-ai-bot]

Comment by redmunds
Saturday Jun 15, 2013 at 00:07 GMT

---

Done with review.

[core-ai-bot]

Comment by TomMalbran
Saturday Jun 15, 2013 at 02:03 GMT

---

@redmunds I applied njx suggestion to use the strings as part of the template variables to fix the issue you mentioned, but had to add the removes third curly brace to the error message.

[core-ai-bot]

Comment by redmunds
Saturday Jun 15, 2013 at 16:44 GMT

---

I applied njx suggestion to use the strings as part of the template variables to fix the issue you mentioned

I agree that is a better solution. I notice that there are other cases with template-based dialogs that use the same code that copies all member of the Strings Object that also need to be updated. Do you want to put up a separate pull request for that, or should I create a new Issue?

[core-ai-bot]

Comment by TomMalbran
Saturday Jun 15, 2013 at 22:11 GMT

---

Sure, I can open a new pull request to fix those other templates.

[core-ai-bot]

Comment by redmunds
Monday Jun 17, 2013 at 15:44 GMT

---

@TomMalbran I opened adobe/brackets#4252 to track the other templates.

[core-ai-bot]

Comment by redmunds
Monday Jun 17, 2013 at 15:45 GMT

---

Thanks@TomMalbran. Merging.