[CLOSED] Add/expose isVisibile, show, and hide methods for SidebarView object

[core-ai-bot]

Issue by lkcampbell
Saturday Mar 30, 2013 at 15:53 GMT
Originally opened as adobe/brackets#3297

---

For Issue #1187

Added public API functions for SidebarView object: show(), hide(), and visible().

Changed public API function: toggleSidebar() to toggle().

Did a find in files for current Brackets codebase and all currently listed Brackets extensions. toggleSidebar() is not used anywhere except for locally in SidebarView.js.

Ran unit tests without any problems. I'm not sure that SidebarView has any unit tests right now. If you want me to research and possibly create unit tests I can. Otherwise, this fix is complete and ready for review.

---

lkcampbell included the following code: https://github.com/adobe/brackets/pull/3297/commits

[core-ai-bot]

Comment by redmunds
Wednesday May 15, 2013 at 21:56 GMT

---

@lkcampbell This looks pretty good.

Line 148 in SidebarView.js:

``` if (!$sidebar.is(":visible")) { ```

should use the new function:

``` if (!visible($sidebar)) { ```

UPDATE: Nevermind. That won't work since it's already a jQuery object.

[core-ai-bot]

Comment by redmunds
Wednesday May 15, 2013 at 23:10 GMT

---

Looks good. Merging.

[core-ai-bot]

Comment by lkcampbell
Friday May 17, 2013 at 04:45 GMT

---

@redmunds and@TomMalbran, new pull request with cleanup submitted.