[CLOSED] Changed all usages of the depreciated ".className" to ".type" that were ...

[core-ai-bot]

Issue by jeffslofish
Thursday May 02, 2013 at 02:10 GMT
Originally opened as adobe/brackets#3697

---

...being used on objects returned from the getTokenAt() method. There are many ".className" references that refer to the name of the CSS class, and all these were left alone. Also, any uses of ".className" in the third party code was left alone as well.

This is for Issue #3676

---

jeffslofish included the following code: https://github.com/adobe/brackets/pull/3697/commits

[core-ai-bot]

Comment by redmunds
Friday May 03, 2013 at 22:23 GMT

---

@jeffslofish Thanks for the pull request. An update has been made to the files in JavaScriptCodeHints that caused a conflict. Please fix so I can merge the code. Thanks.

[core-ai-bot]

Comment by redmunds
Saturday May 04, 2013 at 23:08 GMT

---

@jeffslofish , something it not right about this pull request since you merged. The "Files Changed" tab shows a lot of files that I don't think you changed. I'm hoping it's a temporary quirk with github.com.

One change you do need to make is running github submodule update to update to the SHA of the updated JavaScriptCodeHints submodules. It also looks like you backed out your change to .className in src/extensions/default/JavaScriptCodeHints/Session.js so you should re-fix that while your pushing the other change.

Hopefully, the "Files Changed" tab will be sorted out by then.

[core-ai-bot]

Comment by redmunds
Sunday May 05, 2013 at 17:30 GMT

---

Looks good. Merging.