Issue by lkcampbell
Saturday Aug 24, 2013 at 16:36 GMT
Originally opened as adobe/brackets#4927
Here's the fix for the unit test errors caused by pull request #4878. I moved the check out of the toggle command code and into the _setEditorOption() code per the suggestion of@jasonsanjose.
I also added a new unit test to check for the temporary hiding of the Active Line Highlight when there is an editor selection. Tested the positive and negative scenarios. Ran the entire test suite. Everything looks good. There are still quite a few errors in the unit test suite right now, but none appear to be related to my changes.
lkcampbell included the following code: https://github.com/adobe/brackets/pull/4927/commits
Saturday Aug 24, 2013 at 16:36 GMT
Originally opened as adobe/brackets#4927
Here's the fix for the unit test errors caused by pull request #4878. I moved the check out of the toggle command code and into the _setEditorOption() code per the suggestion of
@jasonsanjose.I also added a new unit test to check for the temporary hiding of the Active Line Highlight when there is an editor selection. Tested the positive and negative scenarios. Ran the entire test suite. Everything looks good. There are still quite a few errors in the unit test suite right now, but none appear to be related to my changes.
lkcampbell included the following code: https://github.com/adobe/brackets/pull/4927/commits