[CLOSED] Persian translation for Brackets

[core-ai-bot]

Issue by myaghobi
Wednesday Sep 11, 2013 at 08:02 GMT
Originally opened as adobe/brackets#5164

---

I've translated brackets to Persian language.

---

myaghobi included the following code: https://github.com/adobe/brackets/pull/5164/commits

[core-ai-bot]

Comment by jasonsanjose
Wednesday Sep 11, 2013 at 20:11 GMT

---

@pgrammer Thanks for the contribution. Please sign the contributor license agreement http://dev.brackets.io/brackets-contributor-license-agreement.html so that we can merge this pull request after it's been reviewed.

Do you happen to know Persian speakers that can review your translation? If not, I'll post to the google group http://groups.google.com/group/brackets-dev looking for help.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Sep 11, 2013 at 20:16 GMT

---

Code review complete. Still needs a translation review and needs to merge master to fix conflicts.

[core-ai-bot]

Comment by myaghobi
Thursday Sep 12, 2013 at 05:19 GMT

---

I signed the contributor license agreement.
Persian language is my native language but I do not know Persian speakers that can review my translation on GitHub.

[core-ai-bot]

Comment by jasonsanjose
Thursday Sep 12, 2013 at 06:08 GMT

---

I've posted to the google group to see if anyone can help with the translation review https://groups.google.com/d/topic/brackets-dev/AH8grjS1PDw/discussion.

[core-ai-bot]

Comment by myaghobi
Monday Sep 30, 2013 at 19:07 GMT

---

why not merge my pullrequest?

[core-ai-bot]

Comment by njx
Monday Sep 30, 2013 at 19:13 GMT

---

Sorry,@jasonsanjose has been on vacation. We normally want at least one other native language speaker to review localization pull requests--it looks like he posted to the brackets-dev Google Group asking for a reviewer but didn't get any response. If you know another native speaker who can review your translation, please have them take a look and comment. I just bumped the thread on the Google Group as well.

[core-ai-bot]

Comment by njx
Monday Sep 30, 2013 at 19:13 GMT

---

@couzteau would you mind tracking this while@jasonsanjose is out? Thanks.

[core-ai-bot]

Comment by couzteau
Monday Sep 30, 2013 at 20:09 GMT

---

@njx sure. will do

[core-ai-bot]

Comment by myaghobi
Monday Sep 30, 2013 at 20:26 GMT

---

Thank you@couzteau.

[core-ai-bot]

Comment by couzteau
Thursday Oct 31, 2013 at 22:38 GMT

---

The file strings.js at src/nls/root also needs to be updated, so that Persian shows up in the language selection dialog: "LOCALE_FA_IR" : "Persian", before Polish

[core-ai-bot]

Comment by couzteau
Thursday Oct 31, 2013 at 22:38 GMT

---

I also spot checked some translations and found no problems.

[core-ai-bot]

Comment by couzteau
Friday Nov 01, 2013 at 18:59 GMT

---

I reviewed the translation via google translate. It all seemed to make sense, no blockers. I'll go ahead withe the merge