[CLOSED] Quick Edit tweak

[core-ai-bot]

Issue by larz0
Monday Sep 16, 2013 at 20:38 GMT
Originally opened as adobe/brackets#5230

---

This is for http://forums.adobe.com/message/5678318#5678318

---

larz0 included the following code: https://github.com/adobe/brackets/pull/5230/commits

[core-ai-bot]

Comment by peterflynn
Tuesday Sep 17, 2013 at 11:59 GMT

---

@larz0 Looks good other than those two comments!

[core-ai-bot]

Comment by julianasuh
Tuesday Sep 17, 2013 at 17:14 GMT

---

Assigned to@njx

[core-ai-bot]

Comment by njx
Monday Sep 23, 2013 at 23:51 GMT

---

@larz0 Looks great - just my one additional comment.

[core-ai-bot]

Comment by njx
Tuesday Sep 24, 2013 at 01:06 GMT

---

@larz0 here's the comment I made - it's hidden right now because it was on one of the outdated diffs:

I think we might need to escape range.name too in _updateRangeLabel(). It happens that it's not necessary for CSS selectors (although it almost is, with >) and JS methods, but in the future if we had, say, LESS support, then there would be things like & in there, and there are other things people could use MultiRangeInlineEditor for that might have syntax that would need to be escaped.

[core-ai-bot]

Comment by larz0
Tuesday Sep 24, 2013 at 05:27 GMT

---

@njx fixed.

[core-ai-bot]

Comment by njx
Tuesday Sep 24, 2013 at 18:00 GMT

---

Looks good. It turns out this broke one of the unit tests due to the string change, so I pushed up a fix for that as well. Merging.