[CLOSED] Menus.removeMenu cleanup: remove all menu items and dividers prior to removing menu

[core-ai-bot]

Issue by lkcampbell
Monday Sep 30, 2013 at 22:42 GMT
Originally opened as adobe/brackets#5384

---

---

lkcampbell included the following code: https://github.com/adobe/brackets/pull/5384/commits

[core-ai-bot]

Comment by lkcampbell
Monday Sep 30, 2013 at 22:44 GMT

---

This fix makes sure that none of the menu items and dividers on the menu being removed are orphaned. It is the final piece of functionality I need (hopefully) to implement a solution for issue #5078.

[core-ai-bot]

Comment by RaymondLim
Thursday Oct 03, 2013 at 05:03 GMT

---

@lkcampbell Thanks for taking care of all the necessary changes for issue #5078. Unfortunately, I won't be able to review and merge this for sprint 32. Will review it when sprint 33 starts on next week.

[core-ai-bot]

Comment by lkcampbell
Thursday Oct 17, 2013 at 13:28 GMT

---

@RaymondLim, if you get some time to commit this pull request this week or early next week, I have the time to submit the "Reload without user extension" pull request next week. That way, we might be able to get the feature in for Sprint 33.

[core-ai-bot]

Comment by RaymondLim
Monday Oct 21, 2013 at 04:00 GMT

---

@lkcampbell
Done with review. Just have one minor nit since you changes are complete and also pretty neat and tidy.

[core-ai-bot]

Comment by lkcampbell
Monday Oct 21, 2013 at 13:51 GMT

---

@RaymondLim, changes for code review done.