[CLOSED] Fix for Issue 1617: Removed all references to CodeHintManager from Editor

[core-ai-bot]

Issue by WebsiteDeveloper
Friday Oct 04, 2013 at 11:35 GMT
Originally opened as adobe/brackets#5421

---

@dangoor to verify that #5412 wasn't introduced.
@RaymondLim since you were the original reviewer

---

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/5421/commits

[core-ai-bot]

Comment by WebsiteDeveloper
Friday Oct 04, 2013 at 13:27 GMT

---

Credits to@jbalsas for finding the fix i incorporated into this pull

[core-ai-bot]

Comment by RaymondLim
Friday Oct 04, 2013 at 16:47 GMT

---

@WebsiteDeveloper
We're closing down sprint 32. So I won't be merging this until sometime next week. In the mean time, can you restore all the white space changes in those files? We understand your intention, but it's not going to help us and it is harder for others to trace the actual changes in those files.

[core-ai-bot]

Comment by WebsiteDeveloper
Tuesday Oct 08, 2013 at 15:53 GMT

---

@RaymondLim i reverted some of the whitespace changes but decided to stop because i would have to revert them each manually.

[core-ai-bot]

Comment by TuckerWhitehouse
Tuesday Oct 08, 2013 at 17:44 GMT

---

Just a heads up, you can view the file changes and ignore any whitespace changes by adding ?w=1 to the end of the url, e.g. https://github.com/adobe/brackets/pull/5421/files?w=1

[core-ai-bot]

Comment by dangoor
Thursday Oct 10, 2013 at 18:25 GMT

---

Good tip,@TuckerWhitehouse

I have verified that #5412 is not re-introduced by this change.

[core-ai-bot]

Comment by WebsiteDeveloper
Thursday Oct 10, 2013 at 19:59 GMT

---

Thanks for checking.

@RaymondLim time to review?

[core-ai-bot]

Comment by RaymondLim
Saturday Oct 12, 2013 at 07:43 GMT

---

@WebsiteDeveloper Done with initial review. I think you need to merge with master to resolve the conflict.

[core-ai-bot]

Comment by WebsiteDeveloper
Saturday Oct 12, 2013 at 16:00 GMT

---

@RaymondLim merged with master and fixed nits

[core-ai-bot]

Comment by WebsiteDeveloper
Saturday Oct 12, 2013 at 16:26 GMT

---

@RaymondLim fixed.

[core-ai-bot]

Comment by RaymondLim
Saturday Oct 12, 2013 at 16:47 GMT

---

Looks good. Merging.