[CLOSED] CSS Quick Edit: Clicking between two rules on same line shows blank line number

[core-ai-bot]

Issue by njx
Tuesday Oct 15, 2013 at 02:11 GMT
Originally opened as adobe/brackets#5517

---

1. Open citrus completed
2. Put the cursor after the <a in one of the nav entries
3. Cmd-E to open Quick Edit
4. In the rule list on the right, click on the second entry (nav ul a:link)
5. Click on the third entry (nav ul a:visited)

Result: line number in the header on the left becomes blank. This only happens if you click on another rule that has the same line number.

[core-ai-bot]

Comment by njx
Tuesday Oct 15, 2013 at 02:12 GMT

---

I'm amazed we've never noticed this before since going through the rules in this case is in the smoke test, but it seems like it's been broken for a long time, and possibly since the beginning.

[core-ai-bot]

Comment by njx
Tuesday Oct 15, 2013 at 02:12 GMT

---

Low pri to me

[core-ai-bot]

Comment by thehogfather
Tuesday Oct 15, 2013 at 14:45 GMT

---

Perhaps it is related to the conditional statement on line 288 of InlineTextEditor.js? It is a little difficult to see the effect of removing that condition (i.e., always update the lineNumber). At the moment that seems to have sorted the bug in my dev copy.

Maybe I'll submit a pull request once I'm fairly confident it doesn't break anything.

[core-ai-bot]

Comment by njx
Tuesday Oct 22, 2013 at 16:57 GMT

---

The original bug was fixed by the fact that we consolidate rules in the rule list now, but you could still potentially hit it when clicking between rules in different files with the same line number. That doesn't reproduce after merging #5582. Closing as fixed.