[CLOSED] Remove modal-wrapper whenever modal dialog is closed

[core-ai-bot]

Issue by WebsiteDeveloper
Friday Oct 18, 2013 at 21:54 GMT
Originally opened as adobe/brackets#5579

---

Old Subject: Issue #5558 and #5548 Dialog fixes

More general fix for issue #5558 (see pull #5559 )
@redmunds
cc@peterflynn

Edit: Incorporated fix for #5548

---

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/5579/commits

[core-ai-bot]

Comment by WebsiteDeveloper
Saturday Oct 19, 2013 at 11:10 GMT

---

@SAPlayer i added the fix for #5548 could you please test this.

[core-ai-bot]

Comment by MarcelGerber
Saturday Oct 19, 2013 at 18:19 GMT

---

Focusing with tab is working, but the arrow keys still don't work.
Also, there are two JSLint errors left (space after if).

[core-ai-bot]

Comment by WebsiteDeveloper
Saturday Oct 19, 2013 at 20:08 GMT

---

@SAPlayer well i plan to add the support for the arrow keys in a subsequent pull request.

[core-ai-bot]

Comment by redmunds
Monday Oct 21, 2013 at 15:07 GMT

---

Done with review. Nice refactoring! Just a couple JSLint errors to fix.

[core-ai-bot]

Comment by WebsiteDeveloper
Monday Oct 21, 2013 at 15:15 GMT

---

@redmunds fixed.

[core-ai-bot]

Comment by redmunds
Monday Oct 21, 2013 at 15:31 GMT

---

Note: I gave this a more descriptive subject. It's best to put bug numbers in description.

[core-ai-bot]

Comment by WebsiteDeveloper
Monday Oct 21, 2013 at 15:32 GMT

---

Will do so in the future.

[core-ai-bot]

Comment by redmunds
Wednesday Oct 23, 2013 at 17:56 GMT

---

@WebsiteDeveloper Any progress on this PR? We really want to get this fixed in Sprint 33 which ends Friday. Thanks.

[core-ai-bot]

Comment by WebsiteDeveloper
Wednesday Oct 23, 2013 at 18:12 GMT

---

@redmunds pushed changes.

[core-ai-bot]

Comment by redmunds
Wednesday Oct 23, 2013 at 18:58 GMT

---

Looks good. Merging.