[CLOSED] For #6093: Added button to show all results in a list

[core-ai-bot]

Issue by MarcelGerber
Sunday Nov 24, 2013 at 18:51 GMT
Originally opened as adobe/brackets#6099

---

This PR adds a button to show all results in a list, as requested in #6093.
Including:

• Make the find-counter clickable
• New string (title attribute of find-counter)

@peterflynn

---

MarcelGerber included the following code: https://github.com/adobe/brackets/pull/6099/commits

[core-ai-bot]

Comment by TomMalbran
Sunday Nov 24, 2013 at 19:38 GMT

---

Nice feature. The new button might need to be put in another place if something like this is done in the Find/Replace UI Cleanup card, and I might also just call it "Find All". But@larz0 would have a better opinion on that.

To Show the status bar, try calling modalBar.close(true, animate); before calling the command.

I am not sure why the busy indicator is not hiding, since it should hide it after the search is done.

[core-ai-bot]

Comment by MarcelGerber
Tuesday Jan 07, 2014 at 20:12 GMT

---

@peterflynn@larz0 Do we still need this after the Find/Replace overhaul?

[core-ai-bot]

Comment by MarcelGerber
Sunday Mar 02, 2014 at 18:14 GMT

---

@peterflynn@larz0 I'm asking again, do we still need this?
I'd like to fit it into the new Find/Replace bar.

[core-ai-bot]

Comment by TomMalbran
Sunday Mar 02, 2014 at 18:49 GMT

---

I wouldn't add this to Find/Replace. I think this could go in Find in Files, by changing the in project text to be a select, where you select the scope, and File can be one of the. I am planning on try this eventually.

[core-ai-bot]

Comment by MarcelGerber
Sunday Mar 02, 2014 at 19:20 GMT

---

But it seems illogical to do Find in Files in order to search just one file.

[core-ai-bot]

Comment by redmunds
Sunday Mar 02, 2014 at 19:31 GMT

---

@TomMalbran You can already do Find In Files in a single file by right-clicking on file in project tree and using Find in....

@SAPlayer sometimes it helps to see the list of hits for a single file in the bottom panel.

[core-ai-bot]

Comment by TomMalbran
Sunday Mar 02, 2014 at 19:36 GMT

---

@redmunds I know, but you can't do a search in the Working Set yet, and sometimes is easier to press ctrl+shift+f and then make it search on the currently selected folder/file.

[core-ai-bot]

Comment by larz0
Sunday Mar 02, 2014 at 19:49 GMT

---

Just make the find-result at the end of the find input a blue "link" that opens up the bottom panel. This will reduce clutter and it also gives context. Would be nice to be able to tab to it as well.

[core-ai-bot]

Comment by redmunds
Sunday Mar 02, 2014 at 20:18 GMT

---

I'd like an option to "Find in Working Set Files"

[core-ai-bot]

Comment by MarcelGerber
Sunday Mar 02, 2014 at 22:43 GMT

---

@redmunds Wonderful idea!

@larz0 So should I carry on with this?

[core-ai-bot]

Comment by TomMalbran
Sunday Mar 02, 2014 at 22:52 GMT

---

I had a Find in Working Set Files command implemented in #3151. So I should get to it in one of the next Find in Files Improvements iteration. But instead of just a command, I thought it might be nice to be able to change the scope inside the find in files bar too.

[core-ai-bot]

Comment by MarcelGerber
Sunday Mar 02, 2014 at 23:15 GMT

---

Yes, that's a good idea and the way Visual Studio (2013) does it:

(current block, selection, current doc, all opened docs (similar to Working Files), current project, all projects)

[core-ai-bot]

Comment by larz0
Sunday Mar 02, 2014 at 23:43 GMT

---

@saplayer I think you should go ahead with that. For all the other drop down items we could put them on top of search history drop down items if we ever get them.

[core-ai-bot]

Comment by MarcelGerber
Monday Mar 03, 2014 at 01:40 GMT

---

Just pushed a commit (sorry, the old ones got lost) to make this PR up-to-date.
The only thing missing is an icon for the button.

[core-ai-bot]

Comment by MarcelGerber
Monday Mar 03, 2014 at 13:16 GMT

---

Another not-so-cool thing: The same search is done twice. Would be better to just pass the results to fill the list.
@TomMalbran Looks like your #7059 (I don't really understand it, sorry) is introducing a new way to fill a search results panel, so it might be the best to wait for that to land in master.