[CLOSED] Switch language / syntax mode of current document

[core-ai-bot]

Issue by peterflynn
Wednesday Jan 08, 2014 at 09:32 GMT
Originally opened as adobe/brackets#6409

---

This is an update of@JakeStoeffler's PR #4276. It's merged up with the latest master and addresses the main code review comments I made there. I also added some simple unit tests.

I still have two concerns about merging this immediately, though:

1) The dropdown UI doesn't look great. It uses a native <select>, which is just hard to style... and the way the statusbar is laid out makes it look misaligned in this case:

It would look nicer if we used an HTML popup like code hints, context menus, and the Recent Projects dropdown... but it would definitely add a bunch more work here. So maybe we can skate by with the current <select>-based UI for now. @larz0, any thoughts?

2) This foregrounds all the bugs in #2911 a lot more. I added a checklist of issues there. Are there any that are prominent enough to act as blockers here? (JS code hints seems like it might be the most glaring issue, but unfortunately that's one of the harder ones to fix too).

---

peterflynn included the following code: https://github.com/adobe/brackets/pull/6409/commits

[core-ai-bot]

Comment by TomMalbran
Wednesday Jan 08, 2014 at 17:02 GMT

---

The algiment issue is caused by the padding around the actual select. The select doesn't have any border, but it still starts where the "LESS" text is. We could fix it by removing the padding around the select and placing it into the select.

[core-ai-bot]

Comment by lkcampbell
Friday Jan 31, 2014 at 03:17 GMT

---

@peterflynn,@jasonsanjose, if you guys are in the process of figuring out the Sprint 37 pull requests to merge, this one gets my vote. This functionality would be very useful, especially if the document specific preference keep track of the language assigned to the document.

[core-ai-bot]

Comment by njx
Tuesday Feb 04, 2014 at 00:50 GMT

---

I added this to Nominations on the Kanban board.

[core-ai-bot]

Comment by busykai
Thursday Feb 27, 2014 at 18:51 GMT

---

@peterflynn, do you have time to merge the current master to this PR? I'll see how bad the issues from your checklist in #2911 look like... The first three seem to be quite important to address.

[core-ai-bot]

Comment by busykai
Friday Feb 28, 2014 at 19:06 GMT

---

@peterflynn, merged master into your branch locally. let me know if you want me to push it to your branch.

bad alignment can be solved by adding left padding and the same amount of negative margin to the select. i have this fix in my local branch as well.

[core-ai-bot]

Comment by peterflynn
Friday Feb 28, 2014 at 19:10 GMT

---

Sounds good -- thanks!

[core-ai-bot]

Comment by TomMalbran
Friday Feb 28, 2014 at 22:44 GMT

---

Instead of using a select can we use something similar to the button dropdown used in the File Filters and CSS Quick Edit, once the File filters are merged?

[core-ai-bot]

Comment by peterflynn
Friday Feb 28, 2014 at 23:02 GMT

---

@TomMalbran That's a great idea! Would probably make it easier to indicate the 'current' value too (e.g. placing a bullet or checkmark next to it as in menu-based picker UIs).

[core-ai-bot]

Comment by TomMalbran
Friday Feb 28, 2014 at 23:05 GMT

---

The design is nicer too and won't have the same problems as the select has now. The checkmarks will look good too. We just need to wait until the Find Filters are merged to be able to use it.

[core-ai-bot]

Comment by busykai
Saturday Mar 01, 2014 at 12:25 GMT

---

@TomMalbran great idea indeed! The native select looks out of the place, but I was struggling to find existing replacement. I'll fetch it once it lands.

[core-ai-bot]

Comment by busykai
Friday Mar 07, 2014 at 00:56 GMT

---

OK, so #7015 has landed, I can take the widget from there now...

[core-ai-bot]

Comment by peterflynn
Friday Mar 07, 2014 at 01:20 GMT

---

Cool, yay!

[core-ai-bot]

Comment by busykai
Tuesday Mar 11, 2014 at 20:48 GMT

---

This is how it looks like with the DropdownButton.

[core-ai-bot]

Comment by larz0
Tuesday Mar 11, 2014 at 20:56 GMT

---

Looks good! Thanks@busykai

[core-ai-bot]

Comment by peterflynn
Tuesday Mar 11, 2014 at 22:36 GMT

---

@busykai Might want to increase the allowable height. In the early usage of this in the file-filtering UI (0bbaf7a5) I used DropdownButton.dropdownExtraClasses to apply a class with max-height: none;. (Though since this list can get quite long, we probably want to pick some reasonable but not unlimited max-height -- sort of like the Quick Open dropdown does).