[CLOSED] Display Inline Editor Errors

[core-ai-bot]

Issue by redmunds
Tuesday Feb 18, 2014 at 22:50 GMT
Originally opened as adobe/brackets#6916

---

This has been implemented using proposal outlined here.

The Quick Docs Feature uses the same mechanism, so it is also supported.

Code handles errors for the CSS, JS, and InlineTimingFunction Inline Editors. Are there any cases that could be handled for the InlineColorEditor? Any other Inline Editors?

TODO:

• immediately dismiss message on:
  • when displaying another inline editor error
  • on scroll
  • change editors
  • selection change
  • edit page
• scroll cursor into view
• unit tests
• determine conflicts with other floating thingies
  • Quick View
  • other Quick Edit or Quick Docs widget
  • main menus (HTML & native)
  • context menu
  • dropdowns (New Rule?)
• UX review
• string review
• any InlineColorEditor error cases that can be handled?
• code review
• rebase
• update quick edit API documentation

---

redmunds included the following code: https://github.com/adobe/brackets/pull/6916/commits

[core-ai-bot]

Comment by redmunds
Wednesday Feb 19, 2014 at 17:14 GMT

---

@larz0 Can you do UX review? Let me know if you review the strings or if someone else should do that.

[core-ai-bot]

Comment by larz0
Wednesday Feb 19, 2014 at 17:26 GMT

---

@redmunds reviewing now.

[core-ai-bot]

Comment by larz0
Wednesday Feb 19, 2014 at 17:38 GMT

---

We need to use the same initial transition as the quick views, the end transition is great. Could we try 2secs instead of 3? Let's make strings shorter as well; could we try:

"Oops, the value is invalid."
"Oops, Quick Edit can't be opened here."
"Oops, Quick Doc can't be opened here."

Maybe@njx has better idea for the strings.

[core-ai-bot]

Comment by redmunds
Wednesday Feb 19, 2014 at 18:01 GMT

---

@larz0

Could we try 2secs instead of 3?

I started with a 3s duration for displaying message, but someone requested 6s so I bumped it up to the current value of 5s. Should I go back to 3s to see how that feels?

[core-ai-bot]

Comment by larz0
Wednesday Feb 19, 2014 at 19:34 GMT

---

Okay cool let's try that.

[core-ai-bot]

Comment by redmunds
Thursday Feb 27, 2014 at 00:59 GMT

---

@larz0 I implemented the transition on open.

But, I did not change the duration message is shown (it's still 5 seconds) because the first time someone sees it they may need more than 3 seconds (that we discussed) between the time it catches their attention and they read it. Instead I implemented the following ways to dismiss message box immediately so people who have seen don't have to wait for it:

• when another message box is being displayed
• click somewhere in page
• edit page
• scroll
• change editors
• Let me know if you think of any other cases

Let me know what you think.

[core-ai-bot]

Comment by larz0
Thursday Feb 27, 2014 at 01:10 GMT

---

@redmunds that's awesome. I found an edge case where if you cmd+e on the same spot again you won't be able to dismiss it via clicking if you've done that the first time.

[core-ai-bot]

Comment by redmunds
Thursday Feb 27, 2014 at 01:51 GMT

---

@larz0 that edge case should be fixed.

[core-ai-bot]

Comment by larz0
Thursday Feb 27, 2014 at 01:57 GMT

---

It's still the same here after I pulled that in. When I click on the tooltip to dismiss it on the same spot for the second time it won't go away. Not sure if it's just me.

[core-ai-bot]

Comment by redmunds
Thursday Feb 27, 2014 at 02:12 GMT

---

It doesn't actually listen for "click in page" it listens for "selection change" -- I updated description above. So it doesn't dismiss if you click in same exact position -- is that OK?

[core-ai-bot]

Comment by larz0
Thursday Feb 27, 2014 at 02:16 GMT

---

Yeah I think that's fine.

[core-ai-bot]

Comment by redmunds
Tuesday Mar 11, 2014 at 16:43 GMT

---

@larz0 Are you done with the UX review? If not, let me know what issues remain.

[core-ai-bot]

Comment by redmunds
Tuesday Mar 11, 2014 at 16:43 GMT

---

@njx Can you do the string review?

[core-ai-bot]

Comment by larz0
Tuesday Mar 11, 2014 at 16:49 GMT

---

Yep I'm done with the UX review. 👍

[core-ai-bot]

Comment by redmunds
Thursday Mar 13, 2014 at 20:55 GMT

---

@JeffryBooher I merged in the latest master. If you think there's enough work here, then go ahead and create a Kanban card for this.