[CLOSED] Add origin parameter to setSelection()/setSelections()

[core-ai-bot]

Issue by njx
Thursday Mar 13, 2014 at 21:35 GMT
Originally opened as adobe/brackets#7196

---

@peterflynn - try this and see if setting an origin in your selection code in everyscrub now merges properly again without having to wrap it in an operation with the replaceRange.

Addresses #7182.

---

njx included the following code: https://github.com/adobe/brackets/pull/7196/commits

[core-ai-bot]

Comment by njx
Friday Mar 14, 2014 at 22:40 GMT

---

Removing "review only" tag - I think we should go ahead and merge this even though it doesn't fix #7182, since it exposes CM functionality that's analogous to the functionality we already expose in Document.replaceRange().

[core-ai-bot]

Comment by peterflynn
Saturday Mar 15, 2014 at 01:18 GMT

---

@njx Yep, this fixes it for everyscrub

[core-ai-bot]

Comment by njx
Saturday Mar 15, 2014 at 01:29 GMT

---

Oh really? You didn't need to wrap it in an operation?

[core-ai-bot]

Comment by njx
Sunday Mar 16, 2014 at 14:45 GMT

---

Ah - apparently it was working for * origins but not + origins (which is what I had tested). Marijn has fixed that in a later patch.

[core-ai-bot]

Comment by njx
Monday Mar 17, 2014 at 13:46 GMT

---

FYI, the fix to this for + origins has also landed.

[core-ai-bot]

Comment by njx
Monday Mar 17, 2014 at 13:48 GMT

---

@redmunds - could you review this one?

[core-ai-bot]

Comment by peterflynn
Monday Mar 17, 2014 at 23:39 GMT

---

Ah, yeah -- everyscrub uses *. And yes, it worked without needing to wrap it in a batch.

[core-ai-bot]

Comment by redmunds
Wednesday Mar 19, 2014 at 00:36 GMT

---

Looks good. Merging.