[CLOSED] Exclude file ext from initial selection when renaming a file.

[core-ai-bot]

Issue by Robo210
Sunday Mar 16, 2014 at 17:15 GMT
Originally opened as adobe/brackets#7209

---

This change performs the rename as usual through JSTree, then
grabs the DOM node and adjusts the selection on it after the fact.
This fixes issue #7019

---

Robo210 included the following code: https://github.com/adobe/brackets/pull/7209/commits

[core-ai-bot]

Comment by zaggino
Monday Mar 17, 2014 at 05:55 GMT

---

Initial review done, works & looks fine.

[core-ai-bot]

Comment by ingorichter
Tuesday Mar 18, 2014 at 17:16 GMT

---

@zaggino could you please finish this review and when you are done please merge. Thanks.

[core-ai-bot]

Comment by zaggino
Tuesday Mar 18, 2014 at 19:34 GMT

---

Ignore comment, good to merge. My blind self.

[core-ai-bot]

Comment by zaggino
Tuesday Mar 18, 2014 at 21:33 GMT

---

@peterflynn - this could be done as a separate PR because it's a bit more complicated. Should we search the languages.json for known extensions that have . in them and use this for selecting?

[core-ai-bot]

Comment by peterflynn
Tuesday Mar 18, 2014 at 21:35 GMT

---

Seems plausible, but I don't know if we have to get that fancy. Your argument above sounded reasonable enough to me -- let's wait & see if we get any feedback about it?

[core-ai-bot]

Comment by Denisov21
Tuesday Mar 18, 2014 at 21:46 GMT

---

Hi,
I think it works well now. I share the opinion on "foo.css.erb" is only the extension *.erb. Thanks for the work guys!

[core-ai-bot]

Comment by zaggino
Tuesday Mar 18, 2014 at 21:55 GMT

---

I don't know - I realized I like the fancy idea and also implementation was just a few lines so I made up a PR and I'll leave to others to merge or not to merge :)

[core-ai-bot]

Comment by zaggino
Tuesday Mar 18, 2014 at 21:59 GMT

---

Btw@peterflynn we do not longer use doublequotes " for strings?
I don't see any "quotmark": "double" in https://github.com/adobe/brackets/blob/master/.jshintrc but I remember I was told to do that before.

[core-ai-bot]

Comment by peterflynn
Tuesday Mar 18, 2014 at 22:02 GMT

---

@zaggino Ah, yes -- all JS code should use double-quoted strings (per style guide). So the string in the lastIndexOf() call here should be fixed. Could you roll that into your PR?

[core-ai-bot]

Comment by zaggino
Tuesday Mar 18, 2014 at 22:07 GMT

---

Already did that for PR. Also tried using "quotmark": "double" in JSHint and it blew out a lof of ' usage, especially in test/ but also 20 or so in src/

[core-ai-bot]

Comment by peterflynn
Wednesday Mar 19, 2014 at 04:27 GMT

---

Seems worth fixing the ones in src at least, though not high priority...